On 05/15/2014 12:12 PM, Herbert Valerio Riedel wrote:
Hello GHC devs,
While I refactored the ghc code base to declare LANGUAGE pragmas locally, rather than via -X-flags on the GHC commandline, I've noticed there were a couple of places where NondecreasingIndentation grammar was used.
What's the current consensus on the use of NondecreasingIndentation? Is its use still encouraged?
----
Moreover, I touched several files (over 300) while refactoring, would that qualify as "working on this module" in the sense of
| While working on this module you are encouraged to remove it and detab | the module (please do the detabbing in a separate patch).
or would that overreach wrt the original intent of the guideline quoted above?
Cheers, hvr _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
Is there a reason behind not just detabbing (and removing trailing whitespace) the whole tree in a patch? If you're going to detab in a separate patch anyway, might as well do all of it once and for all. -- Mateusz K.