| One unfortunate side-effect of keeping WIP work in forks is that GitLab
| will not show the user that the branch has a corresponding MR when
| viewing its commit list. For instance if you look at [1] (a branch in
| the primary GHC repository associated with !298) GitLab will note the
| fact that the branch has an MR open with the "View open merge request"
| button on the top right of the page. However if we look at [2] (in
| osa1's fork, associated with !299) we see no such indication.
This is quite important (to me). On several occasions already I have asked myself "have I opened a MR for this wip/ branch, and if so which MR?". There really should be a way to answer that question.
Simon
| -----Original Message-----
| From: ghc-devs On Behalf Of Ben Gamari
| Sent: 06 February 2019 22:34
| To: Matthew Pickering ; Sylvain Henry
|
| Cc: ghc-devs
| Subject: Re: WIP branches
|
| Matthew Pickering writes:
|
| > Making `ghc-wip` sounds like a reasonable idea to me.
| >
| > I have found that people pushing to the `wip/` branches makes things
| > much smoother so far as it means that I can rebase/finish/amend other
| > people's patches and just push to the same branch without having to
| > ask people to do annoying rebases etc.
| >
| Right, this is a significant advantage of keeping WIP branches in the ghc
| repo. I agree that we should clear out some of the older, non-archival
| wip/ branches.
|
| One unfortunate side-effect of keeping WIP work in forks is that GitLab
| will not show the user that the branch has a corresponding MR when
| viewing its commit list. For instance if you look at [1] (a branch in
| the primary GHC repository associated with !298) GitLab will note the
| fact that the branch has an MR open with the "View open merge request"
| button on the top right of the page. However if we look at [2] (in
| osa1's fork, associated with !299) we see no such indication.
|
| Cheers,
|
| - Ben
|
|
| [1]
| https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha
| skell.org%2Fghc%2Fghc%2Fcommits%2Fwip%2Fnonmoving-
| gc&data=02%7C01%7Csimonpj%40microsoft.com%7Caf97c2f84a6f49e53dac08d68c8
| 32cb2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636850892378883131&s
| data=%2Fdke1u5PQ0U%2F9PMzZBHGkJdR2OZplq2JUGDj8u1YXi8%3D&reserved=0
