Re: [commit: ghc] master: Introduce Int16# and Word16# (36fcf9e)

Hi Gabor, I sent a pull request with a fix to GHC on github. Cheers, Peter

On 18. Nov 2018, at 13:02, Gabor Greif wrote:

Hello Abhiroop!

LLVM backend seems to choke on this still:

ghc-stage1: panic! (the 'impossible' happened) (GHC version 8.7.20181118 for x86_64-unknown-linux): LlvmCodeGen.CodeGen.cmmPrimOpFunctions: MO_S_QuotRem W16 not supported here

Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug

Cheers,

Gabor

On 11/17/18, git@git.haskell.org wrote:

...

Repository : ssh://git@git.haskell.org/ghc

On branch : master Link : http://ghc.haskell.org/trac/ghc/changeset/36fcf9edee31513db2ddbf716ee0aa7976...

...

---------------------------------------------------------------

commit 36fcf9edee31513db2ddbf716ee0aa79766cbe69 Author: Abhiroop Sarkar Date: Mon Nov 5 12:06:58 2018 -0500

Introduce Int16# and Word16#

This builds off of D4475.

Bumps binary submodule.

Reviewers: carter, AndreasK, hvr, goldfire, bgamari, simonmar

Subscribers: rwbarton, thomie

Differential Revision: https://phabricator.haskell.org/D5006

...

---------------------------------------------------------------

36fcf9edee31513db2ddbf716ee0aa79766cbe69 compiler/cmm/CmmUtils.hs | 4 + compiler/codeGen/StgCmmArgRep.hs | 2 + compiler/codeGen/StgCmmPrim.hs | 45 +++++ compiler/prelude/PrelNames.hs | 115 ++++++------ compiler/prelude/TysPrim.hs | 22 ++- compiler/prelude/TysWiredIn.hs | 15 +- compiler/prelude/TysWiredIn.hs-boot | 1 + compiler/prelude/primops.txt.pp | 82 +++++++++ compiler/simplStg/RepType.hs | 2 + compiler/typecheck/TcGenDeriv.hs | 42 ++++- compiler/types/TyCon.hs | 4 + compiler/utils/Binary.hs | 4 + libraries/base/Data/Typeable/Internal.hs | 2 + libraries/binary | 2 +- libraries/ghc-prim/GHC/Types.hs | 6 +- testsuite/tests/ffi/should_run/PrimFFIInt16.hs | 28 +++ .../{PrimFFIInt8.stdout => PrimFFIInt16.stdout} | 0 testsuite/tests/ffi/should_run/PrimFFIInt16_c.c | 7 + testsuite/tests/ffi/should_run/PrimFFIWord16.hs | 28 +++ .../{PrimFFIInt8.stdout => PrimFFIWord16.stdout} | 0 testsuite/tests/ffi/should_run/PrimFFIWord16_c.c | 7 + testsuite/tests/ffi/should_run/all.T | 4 + testsuite/tests/primops/should_run/ArithInt16.hs | 197 +++++++++++++++++++++ .../tests/primops/should_run/ArithInt16.stdout | 8 + testsuite/tests/primops/should_run/ArithWord16.hs | 194 ++++++++++++++++++++ .../tests/primops/should_run/ArithWord16.stdout | 8 + .../primops/should_run/{CmpInt8.hs => CmpInt16.hs} | 34 ++-- .../should_run/{CmpInt8.stdout => CmpInt16.stdout} | 0 .../should_run/{CmpWord8.hs => CmpWord16.hs} | 34 ++-- .../{CmpInt8.stdout => CmpWord16.stdout} | 0 testsuite/tests/primops/should_run/ShowPrim.hs | 16 +- testsuite/tests/primops/should_run/ShowPrim.stdout | 3 +- testsuite/tests/primops/should_run/all.T | 5 + utils/genprimopcode/Main.hs | 4 +- 34 files changed, 809 insertions(+), 116 deletions(-)

Diff suppressed because of size. To see it, use:

git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 36fcf9edee31513db2ddbf716ee0aa79766cbe69 _______________________________________________ ghc-commits mailing list ghc-commits@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-commits

_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs