Re: Nested CPR patch review

I don't think anyone has run nofib on the rebased branch yet. The Akio2017 subpage is a more accurate summary. Sebastian has also been adding notes to explain the more intricate parts. Matt On Fri, Dec 22, 2017 at 5:27 PM, Simon Peyton Jones wrote:

Terrific!

What are the nofib results?

Can we have a couple of artificial benchmarks in cpranal/should_run that show substantial perf improvements because the nested CPR wins in some inner loop?

Is https://ghc.haskell.org/trac/ghc/wiki/NestedCPR still an accurate summary of the idea? And the Akio2017 sub-page? It would be easier to review the code if the design documentation accurately described it.

I'll look in the new year. Thanks!

Simon

| -----Original Message----- | From: Matthew Pickering [mailto:matthewtpickering@gmail.com] | Sent: 22 December 2017 17:09 | To: GHC developers ; Simon Peyton Jones | ; Joachim Breitner ; | tkn.akio@gmail.com; Sebastian Graf | Subject: Nested CPR patch review | | Hi all, | | I recently resurrected akio's nested cpr branch and put it on phabricator | for review. | | https://phabricator.haskell.org/D4244 | | Sebastian has kindly been going over it and ironed out a few kinks in the | last few days. He says now that he believes the patch is correct. | | Is there anything else which needs to be done before merging this patch? | | Simon, would you perhaps be able to give the patch a look over? | | Cheers, | | Matt