Re: Hadrian

Hi, two things. a) why a git subtree if we keep working on github with hadrian, wouldn't that imply using a submodule? We use submodules for all the other ghc boot libs that are not part of the tree and are developed on github as well, no? As far as I understand a subtree, it's essentially integrating everything into the main tree. So this looks more like the submodule to subtree conversion, when hadrian development is switched over to phabricator? b) should we really hardcode the full url to hadrian tickets? wouldn't hadrian/#xxx suffice? Assuming for a moment hadrian would move into the github.com/haskell org or something, while the linkes would likely (due to githubs url redirection) keep on working, until someone recreates a snowleopard/hardian repo, but not necessarily correct anymore. Anyway, let's do this now rather than later. Cheers, moritz

On Oct 20, 2017, at 7:06 AM, Andrey Mokhov wrote:

Hi Ben,

...

Well, the GitHub repo will still exist. Is that enough?

Yes, but I think I'll need to do some clean up in the code so that it's obvious where to look for answers. For example, here is a random comment from a Hadrian source file:

-- Objdump is only required on OpenBSD and AIX, as mentioned in #211.

The reader might confuse this with GHC ticket #211, so I guess this should be replaced with a full link https://github.com/snowleopard/hadrian/issues/211. There may be other potential pitfalls, but hopefully nothing difficult to handle.

I've created an issue to discuss and prepare for the merge: https://github.com/snowleopard/hadrian/issues/440.

Cheers, Andrey

-----Original Message----- From: Ben Gamari [mailto:ben@well-typed.com] Sent: 19 October 2017 21:50 To: Andrey Mokhov ; Boespflug, Mathieu Cc: Jonas Pfenniger Chevalier ; Manuel M T Chakravarty ; ghc-devs Subject: RE: Hadrian

Andrey Mokhov writes:

...

Thanks Ben,

Just to clarify: By history I mean not just commits, but GitHub issues and PRs as well -- together they contain a lot of valuable interlinked information for GHC/Hadrian developers.

Well, the GitHub repo will still exist. Is that enough?

Cheers,

- Ben

_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs