Re: process library broken on Windows

I didn't read closely enough: I see now that it's a warning, not an error. I initially didn't export that constructor since it's only present on Windows for API compatibility, but will never be used. Since this is just the internals module, I can export it, but my preference would in fact be to leave it as-is with the warning. Two alternatives: 1. Create a new hidden module that creates and exports the type constructor, just to hide the warning. I'm -1 on that, since that's extra compile time everyone has to endure just for warning avoidance. 2. base could export CGid for Windows (currently, it does not). On Mon, Nov 2, 2015 at 5:17 AM, Michael Snoyman wrote:

I'll look into this. I just made a new release of process, and was certain I tested on Windows, but perhaps something changed between that commit and release.

On Mon, Nov 2, 2015 at 5:15 AM, Simon Peyton Jones wrote:

...

I’m getting this on HEAD in te ‘

libraries\process\System\Process\Internals.hs:106:16: warning:

Defined but not used: data constructor ‘CGid’

Indeed it looks as if CGId(..) should be exported, else createProcess is unusuable. This looks like the right change. Would someone like to check and make the change

Simon

diff --git a/System/Process/Internals.hs b/System/Process/Internals.hs

index 5575ac4..3e23ad5 100644

--- a/System/Process/Internals.hs

+++ b/System/Process/Internals.hs

@@ -37,6 +37,8 @@ module System.Process.Internals (

#if !defined(mingw32_HOST_OS) && !defined(__MINGW32__)

pPrPr_disableITimers, c_execvpe,

ignoreSignal, defaultSignal,

+#else

+ CGid(..), GroupID, UserID,

#endif

withFilePathException, withCEnvironment,

translate,

_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs