I will do it if Matthew doesn't get to it
Simon
| -----Original Message-----
| From: Ben Gamari [mailto:ben@well-typed.com]
| Sent: 17 November 2015 16:41
| To: Simon Peyton Jones; Matthew Pickering
| Cc: ghc-devs@haskell.org
| Subject: RE: [commit: ghc] master: Remove PatSynBuilderId (2208011)
|
| Simon Peyton Jones writes:
|
| > | I don't think this would work in the case where there are no fields
| > | initialised?
| >
| > Oh yes, silly me. I was thinking that then we wouldn’t need to look at
| > 'labels' at all, but that's not true.
| >
| > Well, at least then I'd replace [PostTc id [FieldLabel] with (PostTc
| > ConLike). This makes it like ConPatOut in HsPat. Then the (Located id)
| > field is redundant (we can get it from the ConLike), but that’s only
| > true after typechecking, so maybe simpler to keep both.
| >
| > It amounts to moving the call to conLikeFieldLabels from tcExpr
| > (RecordCon ...) to dsExpr (RecordCon ...). A small thing but I think
| > it'd be better.
| >
| Mathew, did you ever get to this?
|
| Cheers,
|
| - Ben
