Hello Simon, Sorry for my late reply here, My patch that incorporates you're unused imports fix and some core library updates has recently been merged. This is likely the cause of the errors/warnings you see. I've just checked out a recent master and validated. I do see an unused import in compiler/simplStg/StgLiftLams/LiftM.hs introduced in a commit from earlier today (b2950e03b5). This needs to be fixed, but it's easy: https://phabricator.haskell.org/D5374. Baring that, I don't see any other unused imports when I validate. Looking at the exact error in your email (libraries/containers/Data/IntSet/Internal.hs:198), I see that the line of code is outdated. Please double check that you are on the most recent master (or perhaps b2950e03b5^ to avoid the previously mentioned unused import). Then, since many submodules have been bumped, make sure to do a `git submodule update --init` I suspect this will fix your validate problems. Have a great weekend, David E On 23/11/2018 14:31, Simon Peyton Jones via ghc-devs wrote:
I’m getting lots of these failures. Has someone forgotten to do a submodule update? I’m up to date on a clean head and have done ‘git submodule update’
Help!
Simon
libraries/containers/Data/IntSet/Internal.hs:198:1: error: [-Wunused-imports, -Werror=unused-imports]
The import of ‘<>’ from module ‘Data.Semigroup’ is redundant
|
198 | import Data.Semigroup (Semigroup((<>), stimes), stimesIdempotentMonoid)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
libraries/containers/Data/IntSet/Internal.hs:220:1: error: [-Wunused-imports, -Werror=unused-imports]
The import of ‘Data.Foldable’ is redundant
except perhaps to import instances from ‘Data.Foldable’
To import instances alone, use: import Data.Foldable()
|
220 | import Data.Foldable (Foldable())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
-- David Eichmann, Haskell Consultant Well-Typed LLP, http://www.well-typed.com Registered in England & Wales, OC335890 118 Wymering Mansions, Wymering Road, London W9 2NF, England