| The Discussion tab is ground truth for comments in that you won't miss any
| if you look through it, but it gets cluttered.
Apparently not. Check out
https://gitlab.haskell.org/ghc/ghc/merge_requests/10
and search for "Another module should reference the symbol" which is definitely in a comment.
Maybe I'm missing something.
Simon
| -----Original Message-----
| From: Evan Laforge
| Sent: 04 January 2019 17:13
| To: Richard Eisenberg
| Cc: Simon Peyton Jones ; ghc-devs
| Subject: Re: Gitlab pain
|
| The diff in
| https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha
| skell.org%2Fghc%2Fghc%2Fmerge_requests%2F10%2Fdiffs&data=02%7C01%7Csimo
| npj%40microsoft.com%7C13d19e5c0e4c4398715a08d67267f643%7C72f988bf86f141af91
| ab2d7cd011db47%7C1%7C0%7C636822188176178183&sdata=wJWw5HxSWePGKWWZYEPbr
| dWrhADmIWHalekobnEgiTo%3D&reserved=0
| is the ground truth for the source code. However, it's not ground truth
| for comments. You only get to see the ones attached to the revisions
| selected in "Changes between x and y", which means they tend to get lost.
| The Discussion tab is ground truth for comments in that you won't miss any
| if you look through it, but it gets cluttered.
| There should be a "skip to first unresolved comment" button, which helps.
| I wish it let you cycle them instead of always going to the first. But the
| discussion tab is not good for seeing what the change being discussed
| actually is, so you have to go back to Changes, at which point you lose
| your place in Discussion.
|
| If anyone knows a better way to do comments I'd also like to know... I use
| gitlab at work and find it pretty awkward for medium-and-up sized reviews.
|
| On Sat, Jan 5, 2019 at 12:25 AM Richard Eisenberg
| wrote:
| >
| > GitLab groups posts on lines in MRs as "discussions". A discussion can
| > be *resolved*. When it is resolved, the discussion is collapsed by
| > default when you view the MR. The particular comment you're seeking
| > can be found on the MR if you open the discussion you started at
| > 10:04am this morning (GMT) and that Gabor closed at 2:10pm this
| > afternoon. (I'm already missing comment numbers like in Trac.)
| >
| > I'm still learning my way around, too, so correct me (anyone) if there's
| a better way to describe all this.
| >
| > Richard
| >
| > On Jan 4, 2019, at 11:19 AM, Simon Peyton Jones via ghc-devs wrote:
| >
| > I’m getting lost in a maze of twisty little passages, all alike.
| >
| > I’m looking at
| >
| > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
| > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F10%23note_1877&data=
| > 02%7C01%7Csimonpj%40microsoft.com%7C13d19e5c0e4c4398715a08d67267f643%7
| > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636822188176178183&sda
| > ta=ht6hBYw5rfjSMmpYsmwNnyhxEvHIdjyy%2FLqA2FB1dC8%3D&reserved=0
| >
| > and
| >
| > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
| > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F10&data=02%7C01%7Csi
| > monpj%40microsoft.com%7C13d19e5c0e4c4398715a08d67267f643%7C72f988bf86f
| > 141af91ab2d7cd011db47%7C1%7C0%7C636822188176188191&sdata=1N2eoL7dC
| > 8ElWQ6zyAW4wXBQcaRv4bCk%2FnrrKS%2BlLfI%3D&reserved=0
| >
| >
| >
| > But the note in the former starting “Another module should reference the
| symbol…” doesn’t show up in the latter, anywhere.
| >
| > How can I see the current state of play on this MR, the ground truth?
| >
| > Simon
| >
| > _______________________________________________
| > ghc-devs mailing list
| > ghc-devs@haskell.org
| > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
| > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&data=02%7C01
| > %7Csimonpj%40microsoft.com%7C13d19e5c0e4c4398715a08d67267f643%7C72f988
| > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636822188176188191&sdata=PJj9
| > 2UnmQNNeCFVTt1d8XWSVCcuSAalMJsq152DEfqA%3D&reserved=0
| >
| >
| > _______________________________________________
| > ghc-devs mailing list
| > ghc-devs@haskell.org
| > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
| > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&data=02%7C01
| > %7Csimonpj%40microsoft.com%7C13d19e5c0e4c4398715a08d67267f643%7C72f988
| > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636822188176188191&sdata=PJj9
| > 2UnmQNNeCFVTt1d8XWSVCcuSAalMJsq152DEfqA%3D&reserved=0
