* Like I say I am DEEPLY suspicious of ForallXImplicitBndrs. I can’t make head or tail of it. Is see in you patch you define
type ForallXPat (c :: * -> Constraint) (x :: *) =…
What is this? Why do we need it? What goes wrong if we remove it altogether?
* Likewise `forall thing. Data thing` makes no sense to me as a constraint, even with quantified context. Shayan and I discussed this at ICFP and agreed it made no sense. The hoped-for quantified-context extension is NOT a solution.
Overall I’ve lost track of these enormous constraint tuples that seem to be associated with Data instances. Can you give a small artificial (ie not full GHC) example of why they are necessary? Perhaps it’s this
data T p = T1 (XT1 p) Int
| T1 (XT2 p) (IdP p)
I suppose that a Data instance would need to have
instance (Data (XT1 p), Data (XT2p), Data (IdP p)) => Data IT p) where…
Is that right? In which case why do you have all this PostRn stuff in the DataId type? (And why is it called DataId?)
* “The first approach leads to a spread of the constraint throughout the AST, which gets very messy.” I don’t understand what the first approach is, or why it gets messy. Could you be more concrete?
* “Perhaps the simplest way forward is to get rid of the `thing` parameter completely, and introduce the three or so ImplicitBinders variants that are used.” I don’t’ think it could possibly make anything simpler to have three separate data types. Can you illustrate concretely?
It’d be great to explore these issues with small, concrete examples, rather than the full glory of GHC, both for our own benefit and the benefit of those who will review the patch and (in future) understand the code.
Sorry to be slow
Simon
From: Alan & Kim Zimmerman [mailto:alan.zimm@gmail.com]
Sent: 23 October 2017 22:36
To: Simon Peyton Jones
Cc: ghc-devs@haskell.org
Subject: Re: forall in constraint
In Shayan's implementation he has [1]
data ImplicitBndrs x thing
= IB
(XIB x thing)
thing
| NewImplicitBndrs
(XNewImplicitBndrs x thing)
type family XIB x thing
type family XNewImplicitBndrs x thing
type ForallXImplicitBndrs c x thing =
( c (XIB x thing)
, c (XNewImplicitBndrs x thing)
)
This gets used, in the same file as
type LSigType x = ImplicitBndrs x (LType x)
where `thing` is resolved to a specific type.
Because it is all in the same file, there is no problem making a
constraint on anything using LSigType, that mentions LHsType.
But in the approach I am taking[2], the type families are defined in
HsExtension, which is compiled early in the cycle, and imported by
HsTypes, HsBinds, HsDecl etc.
In order to derive a Data instance for anything using `LSigType x`, we
need to be able to specify that a Data instance exists for `LHsType x`.
So we can either do that directly in HsBinds, or try to add it to the existing
DataId constraint in HsExtension.
The first approach leads to a spread of the constraint throughout the AST,
which gets very messy.
The second approach requires being able to specify a
`forall thing. Data thing` constraint in HsExtension.
I tried an intermediate approach, introducing a constraint in HsDecls[3] to capture this,
but it eventually runs into needing it in the HsExpr.hs-boot file, which means I need
LHsType in that file.
Perhaps the simplest way forward is to get rid of the `thing` parameter completely,
and introduce the three or so ImplicitBinders variants that are used.
I hope this does not just confuse things even more.
Alan
[1] https://github.com/ghc/ghc/blob/wip/GrowableAST/compiler/hsSyn/AST.hs#L475https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc%2Fghc%2Fblob%2Fwip%2FGrowableAST%2Fcompiler%2FhsSyn%2FAST.hs%23L475&data=02%7C01%7Csimonpj%40microsoft.com%7Cd950b40099a34322c49a08d51a5e1892%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636443913792981424&sdata=ZGS3PmcI2nIw%2FRQLDs%2FKWk51LPR4Gmtv9rQHzY1Jre8%3D&reserved=0
[2] https://github.com/ghc/ghc/tree/wip/ttg/2017-10-21https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc%2Fghc%2Ftree%2Fwip%2Fttg%2F2017-10-21&data=02%7C01%7Csimonpj%40microsoft.com%7Cd950b40099a34322c49a08d51a5e1892%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636443913792981424&sdata=WyNfWykERAEKvhfXdSacyvEukkLtEuwvHNgwrbPnkEw%3D&reserved=0
[3] https://github.com/ghc/ghc/commit/22812296818fe955752fa4762cf72250abd09bf9#d...https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc%2Fghc%2Fcommit%2F22812296818fe955752fa4762cf72250abd09bf9%23diff-7cfa6eef12e44d312aca9ef4af0081b3R1439&data=02%7C01%7Csimonpj%40microsoft.com%7Cd950b40099a34322c49a08d51a5e1892%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636443913792981424&sdata=S7kXIL7P5drGmbjcS%2Bd2kNhhHCoCTQStV%2FWqu8CK7i8%3D&reserved=0
On 23 October 2017 at 23:04, Simon Peyton Jones mailto:simonpj@microsoft.com> wrote:
I’m lost. Could you give me a bit more context?
I’m deeply suspicious about that ForallXImplicitBndrs thing with strange higher kinded parameters. Smells all wrong to me.
Simon
