-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 17/11/15 15:15, Richard Eisenberg wrote:
We have such a thing: https://ghc.haskell.org/trac/ghc/wiki/Commentary/CodingStyle
I don't think its widely consulted or respected, though. There are several issues here. (Get rid of tabs v. spaces for instance.) In general it's just too complicated. Successful coding guidelines are in my experience a line or two to explain each point, and then an example or two.
Anyway, I read these, but quickly enough found out that the best strategy was to just try to fit in with the existing code. We should simplify them and make a more pretty site for them. Something like [0], although that's a bit wordy for my taste. Then we need to decide on how to "get there". E.g. do we enforce all new files to follow it rigorously, but adhere to the dominating style of the file you are changing? Do we change the function we are modifying in a patch to adhere to the style? Do we just go through everything all at once and fix it once and for all, like with tabs? I'm not voting for any of them right now, but we need to consider them. [0] http://docs.ganeti.org/ganeti/2.13/html/dev-codestyle.html#haskell - -- Alexander alexander@plaimi.net https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWSzo8AAoJENQqWdRUGk8BuYkQAMVLUfgdYaaduhTCeDBSACjC 9iP8AcmmTsMPbEcSvIA3u2c5wDSxJe1v4kJcglftylcCwLNZQgcVy9k05HlbRbDP CCUS/Glv1TM+s79xueH3ByispjrhZt7yJgdJ5SJbe43i9KyjAG+TaqfgyJRL5oiw 4VKRAfoT2RYm6cjG1WlnzGzDh4QF3y8F9MCZWVgAMbAIDU0gKyR1Mxpf3xSXb02y ObbCKiA3qqITqfjs1ZHXwaJqbg/F21uELS+veGZN149ylimm0zpVzolx9mRgYASv t/b20+qBtDBr/K0BQ/ZPzgx0d9TaYiGF2Jd1AE+m9P9cqPD7qPqljI2/G4Vn0g61 pEburlt4OdSdMlUCmsf3lXBDUMQrXDjBRkh8zMirlt/BzC9a6+9JOfjLixgFlDSV ohy3XmQVokeDWrcFmxz0FPWinU4P+5uQos0Jp/sO+fukRkormM089UYB7vRZVOn9 GtaBCA5FQSvgqfLbDpPDRHfYka5qLPXo9dKtyjjhqEXggwlVCys5rrF+y1B4qs9A XgENKexKtsg7aGc99KZh3t2rF7/jwKsdcVnAbEbyEUvZ9fqvtwZO6DN32YLjNLoV McVeGkLWhtw+ihD/E6VueUxk0ImCr8CpGGMxW7WvyPlQW3v/seU3l7Qezh1PkRZ/ jvj8PUJfGZA/GEZALpIv =tY36 -----END PGP SIGNATURE-----