Re: GitLab cross-posting to Trac?

I really don't think we should emulate trac's behaviour here. As from now all patches will be merged via gitlab it is unnecessary as related merge requests show up visually on each ticket and when a patch is merge the ticket is automatically closed. Ticket numbers mentioned in commits also create references from tickets to commits so you can click the hash to see what the commit was. https://gitlab.com/gitlab-org/gitlab-ce/issues/54621#note_129031655 On Sat, Jan 5, 2019 at 1:31 AM Simon Peyton Jones via ghc-devs wrote:

It's **super-helpful** that the Trac ticket includes, as a comment, the commit(s) that fixed it. Please can this happen with Gitlab too?

Otherwise, when looking at the ticket two years later there is literally no clue what commit (if any) fixed it.

If it can't be done automatically, it must be done manually by each person making a commit. Which is terribly painful. (esp since it can only be done post-CI.)

Thanks

Simon

| -----Original Message----- | From: ghc-devs On Behalf Of Ben Gamari | Sent: 04 January 2019 21:33 | To: Richard Eisenberg ; GHC | Subject: Re: GitLab cross-posting to Trac? | | Richard Eisenberg writes: | | > Hi devs, | > | > With our new GitLab workflow, will commit messages still be posted to | > Issues (once the migration is complete)? That's been really useful | > with Trac. | > | GitLab does not post the commit message to the issues it mentions. It | does create a link to the commit but this doesn't include the commit | message. We could change this with a daemon if we think this would be | helpful. | | Cheers, | | - Ben

_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs