Re: Windows breakage (+patch)

On Wed, 11 Jun 2014 21:35:57 +0300 Sergei Trofimovich wrote:

On Wed, 11 Jun 2014 08:18:30 +0000 Simon Peyton Jones wrote:

...

Stefan, Guys This commit breaks the Windows build (ie my laptop)

commit 9fd507e5758f4141ac2619f0db57136bcab035c6

Author: Sergei Trofimovich

Date: Fri May 23 23:58:06 2014 +0300

Raise exceptions when blocked in bad FDs (fixes Trac #4934) The breakage is this:

C:/code/HEAD/rts/dist/build/libHSrts.a(RtsStartup.o):RtsStartup.c:(.text+0x2aa): undefined reference to `base_GHCziEventziThread_blockedOnBadFD_closure' The reason is, I think that that this line in RtsStartup.c should be inside the guard #ifndef mingw32_HOST_OS

getStablePtr((StgPtr)blockedOnBadFD_closure); I'd do that myself but I am not confident that the fix is correct; and I would like to add a comment to explain why the getStablePtr is non-windows-only. Can someone do this, please?

Oh, I've missed the fact GHC.Event.Thread in a non-windows thing. The whole patch was for posix-only platform, but i tried to export that exception for all platforms.

CCed Simon M.

There is 2 routes: a) move an exception a common module to all platforms. For example to Foreign.C.Error (I've started to prepare a patch)

To avoid import loops and make things clear I've moved it to GHC.Exception.RTS (other from-rts exceptions can be pushded there as well) Patch is in attach. Please review. Thank you! -- Sergei