Re: [commit: testsuite] master: Explain skipping compiler-perf tests when debugging is on (14958ae)

Actually this isn't quite right. compiler_debugged() is true when GhcDebugged=YES in the build system, and GhcDebugged controls whether GHC is compiled with -debug or not. That is, compiler_debugged() tells us whether the compiler was compiled with -debug, not -DDEBUG. The -debug flag links in the debug RTS and doesn't change allocation or heap residency, whereas -DDEBUG enables assertions in the compiler and *does* change allocation and heap residency. It looks like we need another predicate to tell us whether GHC was compiled with -DDEBUG or not. Would you mind backing out these changes in the meantime? Cheers, Simon On 28/11/13 15:55, git@git.haskell.org wrote:

Repository : ssh://git@git.haskell.org/testsuite

On branch : master Link : http://ghc.haskell.org/trac/ghc/changeset/14958ae02b99bafc06288493d186b9313e...

...

---------------------------------------------------------------

commit 14958ae02b99bafc06288493d186b9313ee8c4b9 Author: Joachim Breitner Date: Thu Nov 28 15:56:16 2013 +0000

Explain skipping compiler-perf tests when debugging is on

...

---------------------------------------------------------------

14958ae02b99bafc06288493d186b9313ee8c4b9 driver/testlib.py | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/driver/testlib.py b/driver/testlib.py index bdb91b8..8c8c60d 100644 --- a/driver/testlib.py +++ b/driver/testlib.py @@ -291,6 +291,8 @@ def _compiler_stats_num_field( name, opts, field, expecteds ): if field in opts.compiler_stats_range_fields: framework_fail(name, 'duplicate-numfield', 'Duplicate ' + field + ' num_field check')

+ # Compiler performance numbers change when debugging is on, making the results + # useless and confusing. Therefore, skip if debugging is on. if compiler_debugged(): skip(name, opts)

_______________________________________________ ghc-commits mailing list ghc-commits@haskell.org http://www.haskell.org/mailman/listinfo/ghc-commits