At the moment in HaRe we do use the wrapped location, but it results in
code that is much more complex. This change is more about bringing
predictability to the AST than anything else.
If anyone feels strongly that it should not happen then we can live without
it.
On Mon, Oct 26, 2015 at 2:11 PM, GHC
#11019: ApiAnnotations: Make all RdrName occurences Located -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+-------------------------------------
Comment (by goldfire):
Perhaps I'm missing something very simple, but if you have a, for example, `LHsExpr Name` which matches the pattern `(L loc (HsVar name))`, the `loc` should apply just as well to the `name` as to the overall expression. My understanding of each of the cases above is that they all have this property, so adding another `Located` wrapper would be redundant.
Or am I missing something?
-- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11019#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler