RE: Validate fails: Var/Type length mismatch: [] [s{tv a15I} [tv]]

I can't dig up my old email to ghc-devs right now, but I originally disturbed T149 when I beefed up CorePrep's dead code elimination. I was greener then and sometimes the test passed, so I held off on changing the test. But it is evident now that its expected measurements need to be updated (maybe also making the test more robustly check for CSE). On May 31, 2013 3:48 AM, "Simon Peyton-Jones" wrote:

I don’t know about ghcpkg01. About T149, I’m on a train and can’t check, but I think it’s a common-sub-expression test. It seems to be “working” now, but CSE is quite fragile (I have an idea for how to improve it, but no time to try it out).****

** **

I guess I’ll make it pass, but leave breadcrumbs not to be too surprised if it starts failing agai****

** **

Simon****

** **

*From:* Iavor Diatchki [mailto:iavor.diatchki@gmail.com] *Sent:* 31 May 2013 03:59 *To:* Simon Peyton-Jones; ghc-devs@haskell.org *Subject:* Re: Validate fails: Var/Type length mismatch: [] [s{tv a15I} [tv]]****

** **

Hello,****

** **

sorry about this, I forgot to run validate, and I guess the core-lint did not run in my build.****

** **

I have fixed the problem, and this time I remembered to run "validate", which appears to have mostly worked, except for the 2 problems reported below.****

I don't think that these are related to my change, but I don't really know, so I am not going to push the fix just yet. Could you please advice on how to investigate further?****

** **

-Iavor****

PS: Is there some sort of a flag I could set in build.mk so that it always builds with warnings and core lint? In some of my GHC trees this seems to happen, and in others it does not, and for me it'd be quite helpful if it always did.****

** **

** **

Unexpected results from:****

TEST="T149 ghcpkg01"****

** **

OVERALL SUMMARY for test run started at Thu May 30 19:47:24 PDT 2013****

3657 total tests, which gave rise to****

12141 test cases, of which****

8823 were skipped****

** **

26 had missing libraries****

3233 expected passes****

57 expected failures****

** **

0 caused framework failures****

1 unexpected passes****

1 unexpected failures****

** **

Unexpected passes:****

perf/should_run T149 (normal)****

** **

Unexpected failures:****

cabal ghcpkg01 [bad stderr] (normal)****

** **

** **

** **

** **

** **

On Thu, May 30, 2013 at 4:37 PM, Ian Lynagh wrote:*** *

On Thu, May 30, 2013 at 09:33:43PM +0000, Simon Peyton-Jones wrote:

...

I've pushed a fix.****

Thanks, looks good.

The build then failed compiling GHC.TypeLits, so I've reverted

commit f7fb908ad963f7180c30b55fba57a858b0391de4 Author: Iavor S. Diatchki

which lets the build go through.

Thanks Ian****

_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs****

** **

_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs