Hello Joachim, On 2013-12-05 at 12:56:55 +0100, Joachim Breitner wrote:
Am Donnerstag, den 05.12.2013, 12:15 +0100 schrieb Herbert Valerio Riedel:
PS: I didn't merge in testsuite's Git history as that would bloat ghc.git quite a bit;
would that really be a problem? How different are the numbers?
Here's a rough estimate: testsuite.git current single packfile: 1.8M Dec 5 14:18 .git/objects/pack/pack-5d85ce17a3003e44e0e36d757564ce7df09275d4.idx 27M Dec 5 14:18 .git/objects/pack/pack-5d85ce17a3003e44e0e36d757564ce7df09275d4.pack whereas, when I create a new git repo containing only the HEAD commit from testsuite.git, the resulting single packfile: 204K Dec 5 14:19 .git/objects/pack/pack-27355d714321978fd34c21ce341a7b55f416719a.idx 2.5M Dec 5 14:19 .git/objects/pack/pack-27355d714321978fd34c21ce341a7b55f416719a.pack this seemed to be a significant increase to me;
I’m a fan of keeping history readily available, so unless it really hurts I suggest to do a proper merge.
btw, it'd be easy to provide a simple script which would re-attach the testsuite history (and any other repositories with truncated history) but there's another subtle issue; there's multiple ways to merge in the old testsuite repo, one is without any path-translation, as accomplished by the grafting example I gave; the other is to first rewrite the 'testsuite.git' to have its root-folder being located in a 'testsuite/' folder, so that Git doesn't have to follow renames and thus maybe also simplify navigating/querying the Git history. Cheers, hvr