11 Sep
2015
11 Sep
'15
8:08 a.m.
Jan Stolarek
In general we shouldn't commit anything that breaks validate, because this causes problems for other developers. The right thing to do would be to mark it expect_broken before committing.
Sorry for that. I was actually thinking about marking the test as expect_broken, but then the problem would be completely hidden> I wanted to discuss a possible solution with Simon and Edward first but it looks like Thomas already found a workaround.
Hiding the issue isn't a problem so long as there is a ticket opened to describe the brokeness (and discuss potential solutions). Cheers, - Ben