RE: [commit: ghc] wip/oneShot: Avoid inlining oneShot in unfoldings (16066a1)

| Avoid inlining oneShot in unfoldings
I'm sure there's a reason for this but, again, please say what is, lest I accidentally reverse it in 3 years time.
Simon
| -----Original Message-----
| From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf Of
| git@git.haskell.org
| Sent: 25 October 2014 13:59
| To: ghc-commits@haskell.org
| Subject: [commit: ghc] wip/oneShot: Avoid inlining oneShot in unfoldings
| (16066a1)
|
| Repository : ssh://git@git.haskell.org/ghc
|
| On branch : wip/oneShot
| Link :
| http://ghc.haskell.org/trac/ghc/changeset/16066a165dd7245be58d0fbee265e13
| fb21e2aed/ghc
|
| >---------------------------------------------------------------
|
| commit 16066a165dd7245be58d0fbee265e13fb21e2aed
| Author: Joachim Breitner

Hi, Am Sonntag, den 26.10.2014, 21:04 +0000 schrieb Simon Peyton Jones:
| Avoid inlining oneShot in unfoldings
I'm sure there's a reason for this but, again, please say what is, lest I accidentally reverse it in 3 years time.
don’t worry, this is a very experimental branch, barely enough to run benchmarks. If we are going to add this (which I’m not sure of) there will be proper commits with Notes and everything. Do we need a convention to signal „I know that this commit is horrible by all aspects, don’t waste time reviewing it“? I, for one, don’t expect others to review wip/ branches unless explicitly invited to. But I guess I could also have made this clearer in the commit message. Greetings, Joachim -- Joachim “nomeata” Breitner mail@joachim-breitner.de • http://www.joachim-breitner.de/ Jabber: nomeata@joachim-breitner.de • GPG-Key: 0xF0FBF51F Debian Developer: nomeata@debian.org

Sorry -- I missed the fact that it wasn't on HEAD! Simon | -----Original Message----- | From: ghc-devs [mailto:ghc-devs-bounces@haskell.org] On Behalf Of Joachim | Breitner | Sent: 26 October 2014 23:52 | To: ghc-devs@haskell.org | Subject: Re: [commit: ghc] wip/oneShot: Avoid inlining oneShot in | unfoldings (16066a1) | | Hi, | | | Am Sonntag, den 26.10.2014, 21:04 +0000 schrieb Simon Peyton Jones: | > | Avoid inlining oneShot in unfoldings | > | > I'm sure there's a reason for this but, again, please say what is, lest | I accidentally reverse it in 3 years time. | | don’t worry, this is a very experimental branch, barely enough to run | benchmarks. If we are going to add this (which I’m not sure of) there | will be proper commits with Notes and everything. | | Do we need a convention to signal „I know that this commit is horrible | by all aspects, don’t waste time reviewing it“? I, for one, don’t expect | others to review wip/ branches unless explicitly invited to. But I guess | I could also have made this clearer in the commit message. | | Greetings, | Joachim | | -- | Joachim “nomeata” Breitner | mail@joachim-breitner.de • http://www.joachim-breitner.de/ | Jabber: nomeata@joachim-breitner.de • GPG-Key: 0xF0FBF51F | Debian Developer: nomeata@debian.org
participants (2)
-
Joachim Breitner
-
Simon Peyton Jones