Hi all, Sometimes, the progress on a particular issue is tracked both on Trac and on Phab. What posts should go where? I know Austin is trying to get Trac to be notified when a relevant post happens on Phab -- great. But, if I have a comment, where should I put it? Here is my proposed answer: The Phab reviews are a good place for code-specific commentary/feedback but Trac is better for design issues. A rule of thumb might be to pretend that Phab comments are all forgotten in a month or two, whereas Trac comments are expected to be around in 5 years. Another feature request around Phab/Trac: Is it possible to have a field *at the top of a Trac ticket* that links to the Differential page? Thanks! Richard
| Here is my proposed answer: The Phab reviews are a good place for code- | specific commentary/feedback but Trac is better for design issues. A rule | of thumb might be to pretend that Phab comments are all forgotten in a | month or two, whereas Trac comments are expected to be around in 5 years. Good criterion. I'm littering the Notes in GHC with references to Trac tickets, on the grounds that those tickets will be permanently available. Let's not commit to making the Phab stuff permanently available too. (Of course it may be.) Simon
PS: and if we agree this convention can we document it in our Working Conventions pages? S | -----Original Message----- | From: ghc-devs [mailto:ghc-devs-bounces@haskell.org] On Behalf Of Simon | Peyton Jones | Sent: 14 July 2014 20:25 | To: Richard Eisenberg; ghc-devs@haskell.org | Subject: RE: Phab vs. Trac | | | Here is my proposed answer: The Phab reviews are a good place for code- | | specific commentary/feedback but Trac is better for design issues. A | rule | | of thumb might be to pretend that Phab comments are all forgotten in a | | month or two, whereas Trac comments are expected to be around in 5 | years. | | Good criterion. I'm littering the Notes in GHC with references to Trac | tickets, on the grounds that those tickets will be permanently available. | Let's not commit to making the Phab stuff permanently available too. (Of | course it may be.) | | Simon | _______________________________________________ | ghc-devs mailing list | ghc-devs@haskell.org | http://www.haskell.org/mailman/listinfo/ghc-devs
On Mon, Jul 14, 2014 at 1:41 PM, Richard Eisenberg
Hi all,
Sometimes, the progress on a particular issue is tracked both on Trac and on Phab. What posts should go where? I know Austin is trying to get Trac to be notified when a relevant post happens on Phab -- great. But, if I have a comment, where should I put it?
Here is my proposed answer: The Phab reviews are a good place for code-specific commentary/feedback but Trac is better for design issues. A rule of thumb might be to pretend that Phab comments are all forgotten in a month or two, whereas Trac comments are expected to be around in 5 years.
I think this is the right idea. We're only using Phabricator for code review, which means: - We should only use it to discuss problems pertinent to the implementation or patch someone posts. - Code reviews will always exist, but in practice they are not the most important piece of information. In practice anything requiring a design spec larger than a ticket probably deserves a wiki page and a once-over on the mailing list.
Another feature request around Phab/Trac: Is it possible to have a field *at the top of a Trac ticket* that links to the Differential page?
Good idea! This is now done: https://ghc.haskell.org/trac/ghc/ticket/8634 Look at the top - there is a link to 'Phab:D69', which is the differential revision hyperlinked properly. If you use this syntax in Trac now, it will automatically hyperlink revisions. Perhaps in the future we can shorten it to just 'D69' for example. But this syntax works now to hyperlink directly to Phabricator.
Thanks! Richard _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
-- Regards, Austin Seipp, Haskell Consultant Well-Typed LLP, http://www.well-typed.com/
| Look at the top - there is a link to 'Phab:D69', which is the | differential revision hyperlinked properly. | | If you use this syntax in Trac now, it will automatically hyperlink | revisions. Perhaps in the future we can shorten it to just 'D69' for | example. But this syntax works now to hyperlink directly to | Phabricator. Is this now part of GHC Trac wiki markup syntax generally? Ie can occur in any wiki text? If so, could it be documented? Do we have a place where we collect all GHC-trac-specific Wiki markup? If not, could we have one. Otherwise how would a new person ever find out? Simon
I had no idea about it either; Herbert made me aware of it.
There is a mapping of the 'interwiki syntax' we can use here:
https://ghc.haskell.org/trac/ghc/wiki/InterMapTxt
The 'Phab' syntax is just one of many.
I'll add it to the wiki page!
On Mon, Jul 14, 2014 at 4:37 PM, Simon Peyton Jones
| Look at the top - there is a link to 'Phab:D69', which is the | differential revision hyperlinked properly. | | If you use this syntax in Trac now, it will automatically hyperlink | revisions. Perhaps in the future we can shorten it to just 'D69' for | example. But this syntax works now to hyperlink directly to | Phabricator.
Is this now part of GHC Trac wiki markup syntax generally? Ie can occur in any wiki text? If so, could it be documented? Do we have a place where we collect all GHC-trac-specific Wiki markup? If not, could we have one.
Otherwise how would a new person ever find out?
Simon
-- Regards, Austin Seipp, Haskell Consultant Well-Typed LLP, http://www.well-typed.com/
| There is a mapping of the 'interwiki syntax' we can use here:
|
| https://ghc.haskell.org/trac/ghc/wiki/InterMapTxt
Interesting. That looks useful.
How would one find that page? Is it linked from "Wiki notes" in the left margin box? I don't think so.
As to the content
* What does "This page is interpreted in a special way by Trac" mean?? And the following text. It's utterly opaque to me.
* I believe that the main payload is this: look at the table. If you use Prefix:blah, where Prefix comes from the first column, then you get a link to Site/blah, where Site comes from the second column. Maybe.
* What are the dollars?
* Why do we need links to a cheese shop?
* Are there other useful wiki-isms that are not mentioned here?
Thanks
Simon
| -----Original Message-----
| From: mad.one@gmail.com [mailto:mad.one@gmail.com] On Behalf Of Austin
| Seipp
| Sent: 15 July 2014 04:16
| To: Simon Peyton Jones
| Cc: Austin Seipp; Richard Eisenberg; ghc-devs@haskell.org
| Subject: Re: Phab vs. Trac
|
| I had no idea about it either; Herbert made me aware of it.
|
| There is a mapping of the 'interwiki syntax' we can use here:
|
| https://ghc.haskell.org/trac/ghc/wiki/InterMapTxt
|
| The 'Phab' syntax is just one of many.
|
| I'll add it to the wiki page!
|
| On Mon, Jul 14, 2014 at 4:37 PM, Simon Peyton Jones
|
participants (3)
-
Austin Seipp -
Richard Eisenberg -
Simon Peyton Jones