Re: [commit: ghc] master: Track subrepos Cabal (cc097a4)

Hi Gabor, On Wed, Mar 20, 2013 at 02:38:27PM -0700, Gabor Greif wrote:
commit cc097a43c851891c7a1535d2082c7e392230123d Author: Gabor Greif
Date: Wed Mar 20 22:37:43 2013 +0100 Track subrepos Cabal
If I'm understanding right, this adds a GHC-only patch to fix a couple of typos. Thanks you for your many typo fixes, but in the case of submodules this sort of patch should be sent upstream instead; that way less effort is needed overall, and there is no chance that the patches will be lost when we resync with upstream. We only make GHC-only patches when they are necessary to keep the build working. Thanks Ian

Okay, I'll gladly do that, but what does it mean to "send upstream"?
Simply commit to master? Or is somebody to be consulted before?
Is there a Wiki to sketch the process?
Cheers,
Gabor
On 3/20/13, Ian Lynagh
Hi Gabor,
On Wed, Mar 20, 2013 at 02:38:27PM -0700, Gabor Greif wrote:
commit cc097a43c851891c7a1535d2082c7e392230123d Author: Gabor Greif
Date: Wed Mar 20 22:37:43 2013 +0100 Track subrepos Cabal
If I'm understanding right, this adds a GHC-only patch to fix a couple of typos. Thanks you for your many typo fixes, but in the case of submodules this sort of patch should be sent upstream instead; that way less effort is needed overall, and there is no chance that the patches will be lost when we resync with upstream. We only make GHC-only patches when they are necessary to keep the build working.
Thanks Ian
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs

On Thu, Mar 21, 2013 at 01:21:16AM +0100, Gabor Greif wrote:
Okay, I'll gladly do that, but what does it mean to "send upstream"?
It depends on the library. For Cabal, I guess the best thing would be to send a pull request to https://github.com/haskell/cabal/ ? Thanks Ian

On 3/21/13, Ian Lynagh
On Thu, Mar 21, 2013 at 01:21:16AM +0100, Gabor Greif wrote:
Okay, I'll gladly do that, but what does it mean to "send upstream"?
It depends on the library. For Cabal, I guess the best thing would be to send a pull request to https://github.com/haskell/cabal/ ?
Thanks, Ian, done that. I shall comb through the rest and try to act analogously. Cheers, Gabor
Thanks Ian
participants (2)
-
Gabor Greif
-
Ian Lynagh