RE: [Diffusion] [Build Failed] rGHC0aaea5b8345f: Tiny refactor plus comments
The builds seem to be failing with perf failures for haddock.Cabal haddock.compiler but that doesn't seem to happen for me. It looks as though it started with rGHC*rGHC0b7e538a09bc: Allow recursive unwrapping of data families but since I can't reproduce it, it's hard to investigate. I can't even see what performance number has changed, because harbourmaster only shows the tail of the log. Any insight from others would be useful. Joachim: do the nofib logs show any changes? Simon | -----Original Message----- | From: noreply@phabricator.haskell.org | [mailto:noreply@phabricator.haskell.org] | Sent: 26 June 2015 16:47 | To: Simon Peyton Jones | Subject: [Diffusion] [Build Failed] rGHC0aaea5b8345f: Tiny refactor | plus comments | | Harbormaster failed to build B4562: rGHC0aaea5b8345f: Tiny refactor | plus comments! | | BRANCHES | master | | USERS | simonpj (Author) | GHC - Type checker/inferencer (Auditor) | | COMMIT | https://phabricator.haskell.org/rGHC0aaea5b8345f | | EMAIL PREFERENCES | https://phabricator.haskell.org/settings/panel/emailpreferences/ | | To: simonpj, GHC - Type checker/inferencer
I can't even see what performance number has changed, because harbourmaster only shows the tail of the log.
From https://phabricator.haskell.org/harbormaster/build/4553:
10 bytes allocated value is too high: 11 Expected haddock.Cabal(normal) bytes allocated: 6710234312 +/-5% 12 Lower bound haddock.Cabal(normal) bytes allocated: 6374722596 13 Upper bound haddock.Cabal(normal) bytes allocated: 7045746028 14 Actual haddock.Cabal(normal) bytes allocated: 7417348832 15 Deviation haddock.Cabal(normal) bytes allocated: 10.5 % 16 *** unexpected stat test failure for haddock.Cabal(normal) 17 bytes allocated value is too high: 18 Expected haddock.compiler(normal) bytes allocated: 36740649320 +/-10% 19 Lower bound haddock.compiler(normal) bytes allocated: 33066584388 20 Upper bound haddock.compiler(normal) bytes allocated: 40414714252 21 Actual haddock.compiler(normal) bytes allocated: 40681382656 22 Deviation haddock.compiler(normal) bytes allocated: 10.7 % 23 *** unexpected stat test failure for haddock.compiler(normal)
Hi, Am Freitag, den 26.06.2015, 16:40 +0000 schrieb Simon Peyton Jones:
The builds seem to be failing with perf failures for haddock.Cabal haddock.compiler
but that doesn't seem to happen for me. It looks as though it started with
rGHC*rGHC0b7e538a09bc: Allow recursive unwrapping of data families
I can confirm this, if you look at https://perf.haskell.org/ghc/ you see that that commit is the only in red¹ Here is the report for that commit: https://perf.haskell.org/ghc/#revision/0b7e538a09bc958474ec704063eaa088 36e9270e and you can fetch the numbers from there, or from the full build log at https://raw.githubusercontent.com/nomeata/ghc-speed-logs/master/0b7e538a09bc... It looks very reproducible as well: https://perf.haskell.org/ghc/#graph/tests/alloc/haddock.Cabal;hl=0b7e53 8a09bc958474ec704063eaa08836e9270e Greetings, Joachim ¹ for a very leight, not very aggressive taint of red. -- Joachim “nomeata” Breitner mail@joachim-breitner.de • http://www.joachim-breitner.de/ Jabber: nomeata@joachim-breitner.de • GPG-Key: 0xF0FBF51F Debian Developer: nomeata@debian.org
Hi, Am Freitag, den 26.06.2015, 20:16 +0200 schrieb Joachim Breitner:
Am Freitag, den 26.06.2015, 16:40 +0000 schrieb Simon Peyton Jones:
The builds seem to be failing with perf failures for
haddock.Cabal haddock.compiler
but that doesn't seem to happen for me. It looks as though it started with
rGHC*rGHC0b7e538a09bc: Allow recursive unwrapping of data families
I can confirm this, if you look at https://perf.haskell.org/ghc/ you see that that commit is the only in red¹
Here is the report for that commit: https://perf.haskell.org/ghc/#revision/0b7e538a09bc958474ec704063eaa088 36e9270e and you can fetch the numbers from there, or from the full build log at https://raw.githubusercontent.com/nomeata/ghc-speed-logs/master/0b7e538a09bc...
It looks very reproducible as well: https://perf.haskell.org/ghc/#graph/tests/alloc/haddock.Cabal;hl=0b7e53 8a09bc958474ec704063eaa08836e9270e
has this confusion cleared up? According to https://perf.haskell.org/ghc/#graph/testsuite/unexpected%20stats;hl=0b7 e538a09bc958474ec704063eaa08836e9270e these tests are still failing on my machine. Greetings, Joachim -- Joachim “nomeata” Breitner mail@joachim-breitner.de • http://www.joachim-breitner.de/ Jabber: nomeata@joachim-breitner.de • GPG-Key: 0xF0FBF51F Debian Developer: nomeata@debian.org
It has not, alas. We can revert the change or mark them as broken on the ticket. Then I'll investigate, but #10527 seems like higher priority Simon | -----Original Message----- | From: ghc-devs [mailto:ghc-devs-bounces@haskell.org] On Behalf Of | Joachim Breitner | Sent: 29 June 2015 14:01 | To: ghc-devs@haskell.org | Subject: Re: [Diffusion] [Build Failed] rGHC0aaea5b8345f: Tiny | refactor plus comments | | Hi, | | Am Freitag, den 26.06.2015, 20:16 +0200 schrieb Joachim Breitner: | > Am Freitag, den 26.06.2015, 16:40 +0000 schrieb Simon Peyton Jones: | > > The builds seem to be failing with perf failures for | > > > > haddock.Cabal | > > > > haddock.compiler | > > | > > but that doesn't seem to happen for me. It looks as though it | > > started with | > > | > > rGHC*rGHC0b7e538a09bc: Allow recursive unwrapping of data | > > families | > | > I can confirm this, if you look at | > https://perf.haskell.org/ghc/ | > you see that that commit is the only in red¹ | > | > Here is the report for that commit: | > | https://perf.haskell.org/ghc/#revision/0b7e538a09bc958474ec704063eaa08 | > 8 | > 36e9270e | > and you can fetch the numbers from there, or from the full build log | > at | > https://raw.githubusercontent.com/nomeata/ghc-speed- | logs/master/0b7e53 | > 8a09bc958474ec704063eaa08836e9270e.log | > | > It looks very reproducible as well: | > | https://perf.haskell.org/ghc/#graph/tests/alloc/haddock.Cabal;hl=0b7e5 | > 3 | > 8a09bc958474ec704063eaa08836e9270e | | has this confusion cleared up? According to | https://perf.haskell.org/ghc/#graph/testsuite/unexpected%20stats;hl=0b | 7 | e538a09bc958474ec704063eaa08836e9270e | these tests are still failing on my machine. | | Greetings, | Joachim | | -- | Joachim “nomeata” Breitner | mail@joachim-breitner.de • http://www.joachim-breitner.de/ | Jabber: nomeata@joachim-breitner.de • GPG-Key: 0xF0FBF51F | Debian Developer: nomeata@debian.org
participants (3)
-
Joachim Breitner -
Simon Peyton Jones -
Thomas Miedema