Ben We don't really test with a DEBUG-enabled compiler. And yet, those assertions are all there for a reason. In our CI infrastructure, I wonder if we might do a regression-test run on at least one architecture with DEBUG on? e.g. https://ghc.haskell.org/trac/ghc/ticket/14904 Simon
If we're going to test with a DEBUG-enabled compiler we may also want to enable sanity checks. I've been recently using this a lot and it really catches a lot of bugs that can go unnoticed without sanity checks. I recently filed #15241 for some of the tests that currently fail the sanity checks. Ömer Simon Peyton Jones via ghc-devs <ghc-devs@haskell.org>, 18 Haz 2018 Pzt, 11:35 tarihinde şunu yazdı:
Ben
We don’t really test with a DEBUG-enabled compiler. And yet, those assertions are all there for a reason.
In our CI infrastructure, I wonder if we might do a regression-test run on at least one architecture with DEBUG on?
e.g. https://ghc.haskell.org/trac/ghc/ticket/14904
Simon
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
good idea! | -----Original Message----- | From: Ömer Sinan Ağacan <omeragacan@gmail.com> | Sent: 18 June 2018 09:45 | To: Simon Peyton Jones <simonpj@microsoft.com> | Cc: ghc-devs <ghc-devs@haskell.org> | Subject: Re: DEBUG-on | | If we're going to test with a DEBUG-enabled compiler we may also want to | enable sanity checks. I've been recently using this a lot and it really | catches a lot of bugs that can go unnoticed without sanity checks. I | recently filed #15241 for some of the tests that currently fail the sanity | checks. | | Ömer | | Simon Peyton Jones via ghc-devs <ghc-devs@haskell.org>, 18 Haz 2018 Pzt, | 11:35 tarihinde şunu yazdı: | > | > Ben | > | > We don’t really test with a DEBUG-enabled compiler. And yet, those | assertions are all there for a reason. | > | > In our CI infrastructure, I wonder if we might do a regression-test run on | at least one architecture with DEBUG on? | > | > e.g. https://ghc.haskell.org/trac/ghc/ticket/14904 | > | > Simon | > | > _______________________________________________ | > ghc-devs mailing list | > ghc-devs@haskell.org | > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.h | > askell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&data=02%7C01%7Csi | > monpj%40microsoft.com%7C61cb7f7d0544447dd64c08d5d4f7dfdd%7C72f988bf86f | > 141af91ab2d7cd011db47%7C1%7C0%7C636649083434417033&sdata=a%2FhgLYRxKsb | > 2Mh4RoH9KC1MuIqcf1gzv%2FGRyzc7Sh9w%3D&reserved=0
Simon Peyton Jones via ghc-devs <ghc-devs@haskell.org> writes:
Ben
Hi Simon,
We don't really test with a DEBUG-enabled compiler. And yet, those assertions are all there for a reason. In our CI infrastructure, I wonder if we might do a regression-test run on at least one architecture with DEBUG on? e.g. https://ghc.haskell.org/trac/ghc/ticket/14904
We actually now do precisely this. Since a few weeks ago we have a nightly `validate --slow` (which enables -DDEBUG in the stage 2 compiler) job that runs on the CircleCI infrastructure. Thanks to Alp's work it even appears to pass. However, in light of #14904 I wonder if it we are failing to catch an exit code since it sounds like it should have been failing. Cheers, - Ben
participants (3)
-
Ben Gamari -
Simon Peyton Jones -
Ömer Sinan Ağacan