Re: [commit: ghc] master: Find LLVM tools when version number at end (e.g., llc-3.0) (#7661) (64aaaa1)

On Fri, Feb 15, 2013 at 07:21:54PM +0100, Karel Gardas wrote:
On 02/15/13 07:03 PM, Ian Lynagh wrote:
+ $1=`${FindCmd} ${GOOD_PATH} -type f -perm +111 -maxdepth 1 -regex '.*/$3-[[0-9]]\.[[0-9]]' | ${SortCmd} -n | tail -1`
This feels rather unpleasant to me. Is it likely that someone will have programs called llc-3.0 etc, but no llc?
Yes, Ubuntu 12.04 LTS installs LLVM 3.0 package in a way that, the package binaries are installed into /usr/lib/llvm-3.0 directory and inside /usr/bin there are llc-3.0 and opt-3.0 links created linking to ../lib/llvm-3.0/bin/{llc|opt}.
So David is fixing real-world issue here.
But if you install 'llvm' (rather than 'llvm-3.0') then you get a /usr/bin/llc Analogously, on ubuntu, if you install 'gcc' then you get /usr/bin/gcc, but if you install 'gcc-4.6' then you get /usr/bin/gcc-4.6; but we don't search for gcc-* executables. Thanks Ian

On 02/15/13 07:35 PM, Ian Lynagh wrote:
On Fri, Feb 15, 2013 at 07:21:54PM +0100, Karel Gardas wrote:
On 02/15/13 07:03 PM, Ian Lynagh wrote:
+ $1=`${FindCmd} ${GOOD_PATH} -type f -perm +111 -maxdepth 1 -regex '.*/$3-[[0-9]]\.[[0-9]]' | ${SortCmd} -n | tail -1`
This feels rather unpleasant to me. Is it likely that someone will have programs called llc-3.0 etc, but no llc?
Yes, Ubuntu 12.04 LTS installs LLVM 3.0 package in a way that, the package binaries are installed into /usr/lib/llvm-3.0 directory and inside /usr/bin there are llc-3.0 and opt-3.0 links created linking to ../lib/llvm-3.0/bin/{llc|opt}.
So David is fixing real-world issue here.
But if you install 'llvm' (rather than 'llvm-3.0') then you get a /usr/bin/llc
Yes, but in case of ubuntu this is LLVM 2.9 which is pretty useless on ARM. For ARM you need to install LLVM 3.0. Anyway, please read a description of http://hackage.haskell.org/trac/ghc/ticket/7661 Also I don't lobby for this fix, I'm perfectly happy with --with-llc/--with-opt configure options as I've used them up to now... or even for more simpler workaround like export PATH=/usr/lib/llvm-3.0/bin:$PATH Thanks, Karel
participants (2)
-
Ian Lynagh
-
Karel Gardas