I don't think there is a way to go from the rendered proposal to the pull request, other than the "back" button in your browser. Seriously? But the rendered proposal is the useful link to send to people. There _must_ be a way, even if its indirect. Simon From: Simon Marlow [mailto:marlowsd@gmail.com] Sent: 09 January 2017 16:03 To: Simon Peyton Jones Cc: ghc-devs@haskell.org; Richard Eisenberg Subject: Re: Navigating GHC proposals I don't think there is a way to go from the rendered proposal to the pull request, other than the "back" button in your browser. The constraint-vs-type proposal seems a little bit weird in that it actually has a branch in the ghc-proposals repository itself, rather than being a pull request from a fork in @goldfire's account. Richard, was that intentional? On 9 January 2017 at 13:55, Simon Peyton Jones via ghc-devs mailto:ghc-devs@haskell.org> wrote: Once I am looking the rendered form of a GHC proposal, eg https://github.com/ghc-proposals/ghc-proposals/blob/rae/constraint-vs-type/p...https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fblob%2Frae%2Fconstraint-vs-type%2Fproposals%2F0000-constraint-vs-type.rst&data=02%7C01%7Csimonpj%40microsoft.com%7C79cf69fc14654d88648e08d438a90a1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636195746098640774&sdata=vFOdPskyztyhQRRDIUHq0KMipo62WuWHc6NR0PTXLEY%3D&reserved=0 how can I find my way to the “conversation” for that proposal, so I can comment on it? https://github.com/ghc-proposals/ghc-proposals/pull/32https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F32&data=02%7C01%7Csimonpj%40microsoft.com%7C79cf69fc14654d88648e08d438a90a1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636195746098640774&sdata=WIDk8KnNJ6dpm4q3K%2BUyGt4E8LuSmS%2F29cYpCv7GZnk%3D&reserved=0 Once more, I am lost in a maze of twisty little Githup passages. I clearly have not yet internalised an accurate model of what Github is thinking Thanks Simon _______________________________________________ ghc-devs mailing list ghc-devs@haskell.orgmailto:ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devshttps://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&data=02%7C01%7Csimonpj%40microsoft.com%7C79cf69fc14654d88648e08d438a90a1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636195746098640774&sdata=FMTamv6wS3PdKU1yOSfTnnQfPOlU03EfNx%2B%2BvhWZN4w%3D&reserved=0

That is amazingly indirect. Oh well. Simon From: Simon Marlow [mailto:marlowsd@gmail.com] Sent: 09 January 2017 16:55 To: Simon Peyton Jones Cc: ghc-devs@haskell.org; Richard Eisenberg Subject: Re: Navigating GHC proposals Well, you can go to the history of the file, and from there to the first commit ("Rename proposal file"), and from there you'll see a link to the pull request in the blue box next to the name of the branch (the link looks like "#32" in this case). But really, I wouldn't recommend sending the rendered link to someone, send the link to the pull request. On 9 January 2017 at 16:05, Simon Peyton Jones mailto:simonpj@microsoft.com> wrote: I don't think there is a way to go from the rendered proposal to the pull request, other than the "back" button in your browser. Seriously? But the rendered proposal is the useful link to send to people. There _must_ be a way, even if its indirect. Simon From: Simon Marlow [mailto:marlowsd@gmail.commailto:marlowsd@gmail.com] Sent: 09 January 2017 16:03 To: Simon Peyton Jones mailto:simonpj@microsoft.com> Cc: ghc-devs@haskell.orgmailto:ghc-devs@haskell.org; Richard Eisenberg mailto:rae@cs.brynmawr.edu> Subject: Re: Navigating GHC proposals I don't think there is a way to go from the rendered proposal to the pull request, other than the "back" button in your browser. The constraint-vs-type proposal seems a little bit weird in that it actually has a branch in the ghc-proposals repository itself, rather than being a pull request from a fork in @goldfire's account. Richard, was that intentional? On 9 January 2017 at 13:55, Simon Peyton Jones via ghc-devs mailto:ghc-devs@haskell.org> wrote: Once I am looking the rendered form of a GHC proposal, eg https://github.com/ghc-proposals/ghc-proposals/blob/rae/constraint-vs-type/p...https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fblob%2Frae%2Fconstraint-vs-type%2Fproposals%2F0000-constraint-vs-type.rst&data=02%7C01%7Csimonpj%40microsoft.com%7C79cf69fc14654d88648e08d438a90a1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636195746098640774&sdata=vFOdPskyztyhQRRDIUHq0KMipo62WuWHc6NR0PTXLEY%3D&reserved=0 how can I find my way to the “conversation” for that proposal, so I can comment on it? https://github.com/ghc-proposals/ghc-proposals/pull/32https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F32&data=02%7C01%7Csimonpj%40microsoft.com%7C79cf69fc14654d88648e08d438a90a1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636195746098640774&sdata=WIDk8KnNJ6dpm4q3K%2BUyGt4E8LuSmS%2F29cYpCv7GZnk%3D&reserved=0 Once more, I am lost in a maze of twisty little Githup passages. I clearly have not yet internalised an accurate model of what Github is thinking Thanks Simon _______________________________________________ ghc-devs mailing list ghc-devs@haskell.orgmailto:ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devshttps://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&data=02%7C01%7Csimonpj%40microsoft.com%7C79cf69fc14654d88648e08d438a90a1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636195746098640774&sdata=FMTamv6wS3PdKU1yOSfTnnQfPOlU03EfNx%2B%2BvhWZN4w%3D&reserved=0

On Jan 9, 2017, at 11:03 AM, Simon Marlow wrote:

The constraint-vs-type proposal seems a little bit weird in that it actually has a branch in the ghc-proposals repository itself, rather than being a pull request from a fork in @goldfire's account. Richard, was that intentional?

I like to use GitHub's edit-in-place feature. Previously, I could write my proposal and then GitHub would prepare the pull request by automatically forking the repository (if I hadn't already), making a branch in my own fork, and then posting the PR. Now, however, because I have commit access to ghc-proposals, it only allows me to automatically create a branch at ghc-proposals/ghc-proposals, not goldfirere/ghc-proposals. Was this choice intentional? Not quite -- I didn't originally want to do it this way. But I did know what I was doing when I clicked "go". In retrospect, if all the committee members wrote proposals the way I did, it would clutter ghc-proposals. I'll avoid this in the future, now that I know GitHub won't automatically do what I want when I have commit access. And I've added a link from the rendered version back to the PR. I do think this is a good practice but it must be manually done. Richard