I'm getting the error below. I'm fixing it by changing the backslash to a vertical bar. It's in a comment so I guess that's the right thing to do? Dunno how anyone else's builds work! Simon rts/sm/Storage.c: In function 'allocate': rts/sm/Storage.c:725:13: error: multi-line comment [-Werror=comment] cc1: all warnings being treated as errors Microsoft Research Limited (company number 03369488) is registered in England and Wales Registered office is at 21 Station Road, Cambridge, CB1 2FB
Ah yes, multiline comments are a tricky one and we set -Werror only on
validate builds, so this would have only shown up then (it's easy for
warnings to slip by when compiling the RTS since it's relatively
quick.)
The fix looks fine to me - thank you Simon!
On Tue, Oct 8, 2013 at 8:04 AM, Simon Peyton-Jones
I'm getting the error below. I'm fixing it by changing the backslash to a vertical bar. It's in a comment so I guess that's the right thing to do?
Dunno how anyone else's builds work!
Simon
rts/sm/Storage.c: In function 'allocate': rts/sm/Storage.c:725:13: error: multi-line comment [-Werror=comment] cc1: all warnings being treated as errors
Microsoft Research Limited (company number 03369488) is registered in England and Wales Registered office is at 21 Station Road, Cambridge, CB1 2FB
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
-- Regards, Austin Seipp, Haskell Consultant Well-Typed LLP, http://www.well-typed.com/
My fault, I didn't validate before pushing a comment change. thanks for catching. Edward Excerpts from Simon Peyton-Jones's message of Tue Oct 08 06:04:09 -0700 2013:
I'm getting the error below. I'm fixing it by changing the backslash to a vertical bar. It's in a comment so I guess that's the right thing to do?
Dunno how anyone else's builds work!
Simon
rts/sm/Storage.c: In function 'allocate': rts/sm/Storage.c:725:13: error: multi-line comment [-Werror=comment] cc1: all warnings being treated as errors
Microsoft Research Limited (company number 03369488) is registered in England and Wales Registered office is at 21 Station Road, Cambridge, CB1 2FB
participants (3)
-
Austin Seipp -
Edward Z. Yang -
Simon Peyton-Jones