Re: gitlab upgrade - change in approval system

I would definitely appreciate changing Marge's behavior back to the old one. As things stand currently, I am unable to approve anything that I'm not explicitly listed as a reviewer for. See here [1] for an example of where this has happened. Ryan S. ----- [1] https://gitlab.haskell.org/ghc/ghc/merge_requests/559#note_198714

I have noticed that you can work around this by editing the Mr and adding
yourself explicitly to the approvals list for it.
It then allows you to approve it.
Sent from my Mobile
On Fri, May 17, 2019, 13:54 Ryan Scott
I would definitely appreciate changing Marge's behavior back to the old one. As things stand currently, I am unable to approve anything that I'm not explicitly listed as a reviewer for. See here [1] for an example of where this has happened.
Ryan S. ----- [1] https://gitlab.haskell.org/ghc/ghc/merge_requests/559#note_198714 _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
participants (2)
-
Phyx
-
Ryan Scott