RE: Glasgow Haskell Compiler | Fix #16133 by checking for TypeApplications in rnExpr (!77)

I am now getting lots of email from GitLab, and I’m trying to figure out what they all mean. They come in various forms.
Here’s one puzzler:
* what does the email below mean? Is it a new merge request?
* what is the “!77”?
* What does “RyanGlScott/ghc:wip/T16133 → ghc/ghc:master” mean?
Simon
From: Ryan Scott

For what it's worth, the !77 seems to mean https://gitlab.haskell.org/ghc/ghc/merge_requests/77 which is also the "View it on GitLab" link target. And in general the "!" seems to indicate a merge request, per reference to "!82" mentioning this one. So this does seem to be a new merge request, and presumably the third part is the requested merge from a personal WIP branch to master. On Sun, Jan 6, 2019 at 4:19 PM Simon Peyton Jones via ghc-devs < ghc-devs@haskell.org> wrote:
I am now getting lots of email from GitLab, and I’m trying to figure out what they all mean. They come in various forms.
Here’s one puzzler:
- what does the email below mean? Is it a new merge request? - what is the “!77”? - What does “*RyanGlScott/ghc:wip/T16133 → ghc/ghc:master” *mean?
Simon
*From:* Ryan Scott
*Sent:* 05 January 2019 17:46 *To:* Simon Peyton Jones *Subject:* Glasgow Haskell Compiler | Fix #16133 by checking for TypeApplications in rnExpr (!77) *Project:Branches: RyanGlScott/ghc:wip/T16133 → ghc/ghc:master *
We had a validity check, typeAppErr, for visible *kind* applications (in rnHsTyKi), but didn't extend the same treatment to visible *type* applications (in rnExpr). Easily fixed by also invoking typeAppErr from rnExpr.
Fixes https://ghc.haskell.org/trac/ghc/ticket/16133 https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.haskell.org%2Ftrac%2Fghc%2Fticket%2F16133&data=02%7C01%7Csimonpj%40microsoft.com%7Cbf82903cc44a4d36b9fc08d673359a05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636823071390233674&sdata=1C1YifOb243Ttrz97KqtnAEr9yH0R17qZr0yh%2FgKKRU%3D&reserved=0 .
You're receiving this email because of your account on gitlab.haskell.org. If you'd like to receive fewer emails, you can unsubscribe https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fsent_notifications%2F447feb65a22c202ff644b44f5138d312%2Funsubscribe&data=02%7C01%7Csimonpj%40microsoft.com%7Cbf82903cc44a4d36b9fc08d673359a05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636823071390243688&sdata=xxqzuYyyI4VS%2FsSZ0U10VaYMu9865gAEHDno72uJffw%3D&reserved=0 from this thread or adjust your notification settings. _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
-- brandon s allbery kf8nh allbery.b@gmail.com
participants (2)
-
Brandon Allbery
-
Simon Peyton Jones