RE: [commit: testsuite] master: Revert "Accept unicode quotes in T2507" (937c039)

Interesting. The test failed on my Windows box; I thought it was an oversight. Now you've reverted, it'll fail again. What to do?
Simon
| -----Original Message-----
| From: ghc-commits-bounces@haskell.org [mailto:ghc-commits-
| bounces@haskell.org] On Behalf Of Ian Lynagh
| Sent: 10 March 2013 15:46
| To: ghc-commits@haskell.org
| Subject: [commit: testsuite] master: Revert "Accept unicode quotes in T2507"
| (937c039)
|
| Repository : ssh://darcs.haskell.org//srv/darcs/testsuite
|
| On branch : master
|
| http://hackage.haskell.org/trac/ghc/changeset/937c0399bff9a867fccd8b6e7a63f8
| f25e7b6300
|
| >---------------------------------------------------------------
|
| commit 937c0399bff9a867fccd8b6e7a63f8f25e7b6300
| Author: Ian Lynagh

On Sun, Mar 10, 2013 at 10:36:20PM +0000, Simon Peyton-Jones wrote:
Interesting. The test failed on my Windows box; I thought it was an oversight. Now you've reverted, it'll fail again. What to do?
I don't know if there's an easy way to set a non-Unicode locale on Windows; for now I've marked it as an expected failure.
| commit 937c0399bff9a867fccd8b6e7a63f8f25e7b6300 | Author: Ian Lynagh
| Date: Sun Mar 10 15:41:48 2013 +0000 | | Revert "Accept unicode quotes in T2507" | | T2507 sets LC_ALL=C, so doesn't run in a Unicode locale, and shouldn't | have unicode quotes.
Thanks Ian

| I don't know if there's an easy way to set a non-Unicode locale on
| Windows; for now I've marked it as an expected failure.
Is there a ticket for this bug?
S
| -----Original Message-----
| From: Ian Lynagh [mailto:ian@well-typed.com]
| Sent: 12 March 2013 00:55
| To: Simon Peyton-Jones
| Cc: ghc-devs@haskell.org
| Subject: Re: [commit: testsuite] master: Revert "Accept unicode quotes
| in T2507" (937c039)
|
| On Sun, Mar 10, 2013 at 10:36:20PM +0000, Simon Peyton-Jones wrote:
| > Interesting. The test failed on my Windows box; I thought it was an
| oversight. Now you've reverted, it'll fail again. What to do?
|
| I don't know if there's an easy way to set a non-Unicode locale on
| Windows; for now I've marked it as an expected failure.
|
| > | commit 937c0399bff9a867fccd8b6e7a63f8f25e7b6300
| > | Author: Ian Lynagh

On Tue, Mar 12, 2013 at 08:26:46AM +0000, Simon Peyton-Jones wrote:
| I don't know if there's an easy way to set a non-Unicode locale on | Windows; for now I've marked it as an expected failure.
Is there a ticket for this bug?
No, but the bug is in the testcase, not in GHC. Is it worth making a ticket for it? Thanks Ian

Oh, I thought the bug was that we don't know how to set a non-Unicode locale on Windows. Maybe it's not possible (ie bug in windows). Anyway, I don't mind! Regardless, worth commenting the expect-broken to say why. Maybe you already have. I'll go away now :-) Simon | -----Original Message----- | From: Ian Lynagh [mailto:ian@well-typed.com] | Sent: 12 March 2013 16:07 | To: Simon Peyton-Jones | Cc: ghc-devs@haskell.org | Subject: Re: [commit: testsuite] master: Revert "Accept unicode quotes | in T2507" (937c039) | | On Tue, Mar 12, 2013 at 08:26:46AM +0000, Simon Peyton-Jones wrote: | > | I don't know if there's an easy way to set a non-Unicode locale on | > | Windows; for now I've marked it as an expected failure. | > | > Is there a ticket for this bug? | | No, but the bug is in the testcase, not in GHC. Is it worth making a | ticket for it? | | | Thanks | Ian
participants (2)
-
Ian Lynagh
-
Simon Peyton-Jones