Hi, Did something change in pretty-printing recently? I saw these new validate failures today: Unexpected failures: ghci.debugger/scripts break008 [bad stdout] (ghci) ghci.debugger/scripts break012 [bad stdout] (ghci) ghci.debugger/scripts break026 [bad stdout] (ghci) ghci.debugger/scripts hist001 [bad stdout] (ghci) ghci/scripts T5545 [bad stdout] (ghci) ghci/scripts ghci008 [bad stdout] (ghci) ghci/scripts ghci012 [bad stdout] (ghci) ghci/scripts ghci023 [bad stdout] (ghci) ghci/scripts ghci025 [bad stdout] (ghci) ghci/scripts ghci026 [bad stdout] (ghci) ghci/scripts ghci055 [bad stdout] (ghci) Two example stdout changes: --- ./T5545.stdout 2014-03-13 09:48:23.000000000 +0100 +++ ./T5545.run.stdout 2014-03-13 21:11:32.000000000 +0100 @@ -1,2 +1,2 @@ -($!) :: (a -> b) -> a -> b -- Defined in 'Prelude' +$! :: forall a b. (a -> b) -> a -> b -- Defined in 'Prelude' infixr 0 $! *** unexpected failure for T5545(ghci) --- ./ghci008.stdout 2014-03-13 09:48:23.000000000 +0100 +++ ./ghci008.run.stdout 2014-03-13 21:12:20.000000000 +0100 @@ -32,5 +32,5 @@ -- Defined in 'GHC.Float' instance RealFloat Float -- Defined in 'GHC.Float' instance RealFloat Double -- Defined in 'GHC.Float' -Data.List.isPrefixOf :: Eq a => [a] -> [a] -> Bool +isPrefixOf :: forall a. Eq a -> [a] -> [a] -> Bool -- Defined in 'Data.List' *** unexpected failure for ghci008(ghci)
On 13/03/14 20:13, Johan Tibell wrote:
Hi,
Did something change in pretty-printing recently? I saw these new validate failures today:
Unexpected failures: ghci.debugger/scripts break008 [bad stdout] (ghci) ghci.debugger/scripts break012 [bad stdout] (ghci) ghci.debugger/scripts break026 [bad stdout] (ghci) ghci.debugger/scripts hist001 [bad stdout] (ghci) ghci/scripts T5545 [bad stdout] (ghci) ghci/scripts ghci008 [bad stdout] (ghci) ghci/scripts ghci012 [bad stdout] (ghci) ghci/scripts ghci023 [bad stdout] (ghci) ghci/scripts ghci025 [bad stdout] (ghci) ghci/scripts ghci026 [bad stdout] (ghci) ghci/scripts ghci055 [bad stdout] (ghci)
Two example stdout changes:
--- ./T5545.stdout 2014-03-13 09:48:23.000000000 +0100 +++ ./T5545.run.stdout 2014-03-13 21:11:32.000000000 +0100 @@ -1,2 +1,2 @@ -($!) :: (a -> b) -> a -> b -- Defined in 'Prelude' +$! :: forall a b. (a -> b) -> a -> b -- Defined in 'Prelude' infixr 0 $! *** unexpected failure for T5545(ghci)
--- ./ghci008.stdout 2014-03-13 09:48:23.000000000 +0100 +++ ./ghci008.run.stdout 2014-03-13 21:12:20.000000000 +0100 @@ -32,5 +32,5 @@ -- Defined in 'GHC.Float' instance RealFloat Float -- Defined in 'GHC.Float' instance RealFloat Double -- Defined in 'GHC.Float' -Data.List.isPrefixOf :: Eq a => [a] -> [a] -> Bool +isPrefixOf :: forall a. Eq a -> [a] -> [a] -> Bool -- Defined in 'Data.List' *** unexpected failure for ghci008(ghci)
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
Perhaps https://ghc.haskell.org/trac/ghc/changeset/24eea38c70eae90d166de26d71a178fb0... has something to do with it. AFAIK it's part of https://ghc.haskell.org/trac/ghc/ticket/8776 -- Mateusz K.
Hi, Am Donnerstag, den 13.03.2014, 21:13 +0100 schrieb Johan Tibell:
Did something change in pretty-printing recently? I saw these new validate failures today:
Unexpected failures: ghci.debugger/scripts break008 [bad stdout] (ghci) ghci.debugger/scripts break012 [bad stdout] (ghci) ghci.debugger/scripts break026 [bad stdout] (ghci) ghci.debugger/scripts hist001 [bad stdout] (ghci) ghci/scripts T5545 [bad stdout] (ghci) ghci/scripts ghci008 [bad stdout] (ghci) ghci/scripts ghci012 [bad stdout] (ghci) ghci/scripts ghci023 [bad stdout] (ghci) ghci/scripts ghci025 [bad stdout] (ghci) ghci/scripts ghci026 [bad stdout] (ghci) ghci/scripts ghci055 [bad stdout] (ghci)
confirmed by travis, according to https://travis-ci.org/nomeata/ghc-complete/builds the breaking change was one of commit 065c35a9d6d48060c8fac8d755833349ce58b35b Author: Dr. ERDI Gergo <gergo@erdi.hu> Date: Thu Mar 13 21:18:39 2014 +0800 Pretty-print the following TyThings via their IfaceDecl counterpart: * AnId * ACoAxiom * AConLike commit 24eea38c70eae90d166de26d71a178fb0c1ffc30 Author: Dr. ERDI Gergo <gergo@erdi.hu> Date: Wed Mar 12 20:38:54 2014 +0800 pprIfaceDecl for IfacePatSyn: use pprPatSynSig commit 23c0f1ec2cf06c0178c2ae7414fe57ea648689e7 Author: Dr. ERDI Gergo <gergo@erdi.hu> Date: Wed Mar 12 20:38:26 2014 +0800 pprIfaceContextArr: print a context including the "=>" arrow commit 4d1b7b4a9b986e87755784478b4ea4883a5e203e Author: Dr. ERDI Gergo <gergo@erdi.hu> Date: Wed Mar 12 20:37:22 2014 +0800 Add OutputableBndr instance for OccName Gergo, can you have a look and fix that? Thanks, Joachim -- Joachim “nomeata” Breitner mail@joachim-breitner.de • http://www.joachim-breitner.de/ Jabber: nomeata@joachim-breitner.de • GPG-Key: 0x4743206C Debian Developer: nomeata@debian.org
participants (3)
-
Joachim Breitner -
Johan Tibell -
Mateusz Kowalczyk