tar --help is failing on Solaris.

Hello Mikhail, you are the author of the patch eaf2aae18603965ff668384b391fcaa14de19823 in libraries/Cabal which you have merged into GHC HEAD on September 25 in the patch 4be50969491aa471d6c9ab3b9339036a355d45c6 The problem is that your patch breaks build on Solaris, here is the log from the Solaris/x86 builder: http://haskell.inf.elte.hu/builders/solaris-x86-head/178/10.html Could you be so kind and revert this patch or fix it to also work on Solaris? For Solaris the change should be easy, simply if you invoke Solaris' tar with --help, it'll fail with exit code 1 and help message printed into the stderr. If you are curious if it supports --format, then no. Please let me know if you are able to push fix or revert during next week or if I shall deal with it myself. I can't just fix that now myself since I'm overloaded with other tasks till Wednesday night... Thanks! Karel

Hi Karel,
On 27 September 2014 20:19, Karel Gardas
[...] Could you be so kind and revert this patch or fix it to also work on Solaris? For Solaris the change should be easy, simply if you invoke Solaris' tar with --help, it'll fail with exit code 1 and help message printed into the stderr. If you are curious if it supports --format, then no.
Should be fixed now. Thanks for the heads-up!

Hi Mikhail, On 09/27/14 09:09 PM, Mikhail Glushenkov wrote:
On 27 September 2014 20:19, Karel Gardas
wrote: [...] Could you be so kind and revert this patch or fix it to also work on Solaris? For Solaris the change should be easy, simply if you invoke Solaris' tar with --help, it'll fail with exit code 1 and help message printed into the stderr. If you are curious if it supports --format, then no.
Should be fixed now. Thanks for the heads-up!
Have you already pushed? I don't see it fixed on my end yet: "inplace/bin/ghc-cabal" configure libraries/binary dist-boot "" --with-ghc="/opt/ghc-7.8.2/bin/ghc" --with-ghc-pkg="/opt/ghc-7.8.2/bin/ghc-pkg" --package-db=/export/home/karel/vcs/ghc-src/tar-test/libraries/bootstrapping.conf --disable-library-for-ghci --enable-library-vanilla --disable-library-profiling --disable-shared --with-hscolour="/export/home/karel/.cabal/bin/HsColour" --configure-option=CFLAGS=" -U__i686 -fno-stack-protector " --configure-option=LDFLAGS=" " --configure-option=CPPFLAGS=" " --gcc-options=" -U__i686 -fno-stack-protector " --configure-option=--with-gmp-includes="/usr/include/gmp/" --configure-option=--with-gmp-libraries="/usr/lib/" --constraint "binary == 0.7.1.0" --constraint "Cabal == 1.21.1.0" --constraint "hpc == 0.6.0.2" --constraint "bin-package-db == 0.0.0.0" --constraint "hoopl == 3.10.0.2" --constraint "transformers == 0.4.1.0" --constraint "terminfo == 0.4.0.0" --with-gcc="/usr/bin//gcc" --configure-option=--with-cc="/usr/bin//gcc" --with-ar="/usr/xpg4/bin//ar" --with-alex="/export/home/karel/.cabal/bin/alex" --with-happy="/export/home/karel/.cabal/bin/happy" Configuring binary-0.7.1.0... ghc-cabal: '/usr/bin/tar' exited with an error: Usage: tar {c|r|t|u|x}[BDeEFhilmnopPTvw@/[0-7]][bf][X...] [j|z|Z] [blocksize] [tarfile] [size] [exclude-file...] {file | -I include-file | -C directory file}... gmake[1]: *** [libraries/binary/dist-boot/package-data.mk] Error 1 gmake: *** [all] Error 2 and I've got whole new ghc tree for this test... Thanks! Karel

On 2014-09-27 at 21:46:13 +0200, Karel Gardas wrote:
Hi Mikhail,
On 09/27/14 09:09 PM, Mikhail Glushenkov wrote:
On 27 September 2014 20:19, Karel Gardas
wrote: [...] Could you be so kind and revert this patch or fix it to also work on Solaris? For Solaris the change should be easy, simply if you invoke Solaris' tar with --help, it'll fail with exit code 1 and help message printed into the stderr. If you are curious if it supports --format, then no.
Should be fixed now. Thanks for the heads-up!
Have you already pushed? I don't see it fixed on my end yet:
fyi, libraries/Cabal is a submodule, so here's what you should do, (assuming you've ghc's checkout is at its latest state): # update/checkout submodule to latest commit from Cabal's master branch git submodule update --remote libraries/Cabal # test ./validate still works # record submodule update in git index git add libraries/Cabal # create commit, and make sure the commit msg contains the # magic word "submodule" git commit # ... git push HTH, hvr
participants (3)
-
Herbert Valerio Riedel
-
Karel Gardas
-
Mikhail Glushenkov