Warning on tabs by default (#9230) for GHC 7.10

Hi all, Please see here: https://phabricator.haskell.org/D255 and https://ghc.haskell.org/trac/ghc/ticket/9230 Making tabs warn by default has been requested many times before, and now that the compiler is completely detabbed, this should become possible to enable easily, and we can gradually remove warnings from everything else. Unless someone has huge complaints or this becomes a gigantic bikeshed/review (bike-review), please let me know - I would like this to go in for 7.10. -- Regards, Austin Seipp, Haskell Consultant Well-Typed LLP, http://www.well-typed.com/

On 10/18/2014 01:25 AM, Austin Seipp wrote:
Hi all,
Please see here:
https://phabricator.haskell.org/D255 and https://ghc.haskell.org/trac/ghc/ticket/9230
Making tabs warn by default has been requested many times before, and now that the compiler is completely detabbed, this should become possible to enable easily, and we can gradually remove warnings from everything else.
Unless someone has huge complaints or this becomes a gigantic bikeshed/review (bike-review), please let me know - I would like this to go in for 7.10.
On Phabricator I see a diff which adds a suppression for the warning to GHC. Is this necessary considering you say GHC is now fully detabbed? -- Mateusz K.

The boot libraries have not been detabbed, and that's something we
can't immediately fix. However, the warnings being on by default means
people should feel the burn to fix it quickly, I hope, and we can just
update all of our submodules accordingly.
I did notice however in the diff that I missed the fact `hsc2hs` has
also not been detabbed. That can be fixed immediately, however.
On Sat, Oct 18, 2014 at 5:30 PM, Mateusz Kowalczyk
On 10/18/2014 01:25 AM, Austin Seipp wrote:
Hi all,
Please see here:
https://phabricator.haskell.org/D255 and https://ghc.haskell.org/trac/ghc/ticket/9230
Making tabs warn by default has been requested many times before, and now that the compiler is completely detabbed, this should become possible to enable easily, and we can gradually remove warnings from everything else.
Unless someone has huge complaints or this becomes a gigantic bikeshed/review (bike-review), please let me know - I would like this to go in for 7.10.
On Phabricator I see a diff which adds a suppression for the warning to GHC. Is this necessary considering you say GHC is now fully detabbed?
-- Mateusz K. _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
-- Regards, Austin Seipp, Haskell Consultant Well-Typed LLP, http://www.well-typed.com/

I guess template-haskell should be also easy to detab immediately. It is the only thing in ./libraries that is not a git submodule. Best, Mateusz Lenik On Sat, Oct 18, 2014 at 05:48:26PM -0500, Austin Seipp wrote:
The boot libraries have not been detabbed, and that's something we can't immediately fix. However, the warnings being on by default means people should feel the burn to fix it quickly, I hope, and we can just update all of our submodules accordingly.
I did notice however in the diff that I missed the fact `hsc2hs` has also not been detabbed. That can be fixed immediately, however.
On Sat, Oct 18, 2014 at 5:30 PM, Mateusz Kowalczyk
wrote: On 10/18/2014 01:25 AM, Austin Seipp wrote:
Hi all,
Please see here:
https://phabricator.haskell.org/D255 and https://ghc.haskell.org/trac/ghc/ticket/9230
Making tabs warn by default has been requested many times before, and now that the compiler is completely detabbed, this should become possible to enable easily, and we can gradually remove warnings from everything else.
Unless someone has huge complaints or this becomes a gigantic bikeshed/review (bike-review), please let me know - I would like this to go in for 7.10.
On Phabricator I see a diff which adds a suppression for the warning to GHC. Is this necessary considering you say GHC is now fully detabbed?
-- Mateusz K. _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
-- Regards,
Austin Seipp, Haskell Consultant Well-Typed LLP, http://www.well-typed.com/ _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs

Making tabs warn by default has been requested many times before, and now that the compiler is completely detabbed, this should become possible to enable easily, and we can gradually remove warnings from everything else.
I hate this, but I assume there will be an easy flag to turn this warning off that I can put in all of my builds. -- Stephen Paul Weber, @singpolyma See http://singpolyma.net for how I prefer to be contacted edition right joseph

Yes, all you need to do is to add -fno-warn-tabs to ghc-options. On Tue, Oct 21, 2014 at 10:54:31AM -0500, Stephen Paul Weber wrote:
Making tabs warn by default has been requested many times before, and now that the compiler is completely detabbed, this should become possible to enable easily, and we can gradually remove warnings from everything else.
I hate this, but I assume there will be an easy flag to turn this warning off that I can put in all of my builds.
-- Stephen Paul Weber, @singpolyma See http://singpolyma.net for how I prefer to be contacted edition right joseph _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
-- Mateusz Lenik
participants (4)
-
Austin Seipp
-
Mateusz Kowalczyk
-
Mateusz Lenik
-
Stephen Paul Weber