GItLab commenting

Simon Peyton Jones

14 Feb 2019 14 Feb '19

4:38 a.m.

Friends In reviewing MR!361, I wanted to point out that a Note on line 1481 of a file needed rewriting. But the patch only modified lines 236 or so. How can I get it to display line 1481? (Or, more simply, just display the whole file?) I can get it to show 10 more lines at a time by clicking the little grey "..." symbols. But getting 1000 lines down would take 100 clicks - hardly sensible. Moreover, what if I want to comment on a file that isn't in the patch at all? Thanks Simon

Attachments:

attachment.html (text/html — 3.1 KB)

Show replies by date

Julian Leviston

15 Feb 15 Feb

6:04 p.m.

...

On 14 Feb 2019, at 8:38 pm, Simon Peyton Jones via ghc-devs wrote:

Friends

In reviewing MR!361, I wanted to point out that a Note on line 1481 of a file needed rewriting. But the patch only modified lines 236 or so. How can I get it to display line 1481? (Or, more simply, just display the whole file?)

I can get it to show 10 more lines at a time by clicking the little grey “…” symbols. But getting 1000 lines down would take 100 clicks – hardly sensible.

Moreover, what if I want to comment on a file that isn’t in the patch at all?

Thanks

Simon

Hi Simon, Go to the source code that you want to refer to, (Repository… Files for example, or even within an MR itself)… and you’ll notice if you hover on the LHS of any source code, next to the line numbers, that it has a little link icon. Clicking that will change the URL in the URL bar to refer to that place (you can also shift-click between two lines to create a range if that’s your particular proclivity). You can copy the link from the URL bar, and then paste it into the comment where you want to refer to the line of code in question. Warmest regards, Julian

Simon Peyton Jones

18 Feb 18 Feb

4:22 a.m.

Go to the source code that you want to refer to, (Repository… Files for example, or even within an MR itself)… and you’ll notice if you hover on the LHS of any source code, next to the line numbers, that it has a little link icon. Clicking that will change the URL in the URL bar to refer to that place (you can also shift-click between two lines to create a range if that’s your particular proclivity). You can copy the link from the URL bar, and then paste it into the comment where you want to refer to the line of code in question. My goal is to add a comment to a line in the MR that is not displayed by the MR If the line is displayed, then yes I can do what you say. But it isn’t! Zooming off to the repository is not good because while I can get a link to the line, I can’t add a comment; I can only do that in the MR. Does that make sense? Simon From: Julian Leviston Sent: 15 February 2019 23:04 To: Simon Peyton Jones Cc: GHC developers Subject: Re: GItLab commenting On 14 Feb 2019, at 8:38 pm, Simon Peyton Jones via ghc-devs mailto:ghc-devs@haskell.org> wrote: Friends In reviewing MR!361, I wanted to point out that a Note on line 1481 of a file needed rewriting. But the patch only modified lines 236 or so. How can I get it to display line 1481? (Or, more simply, just display the whole file?) I can get it to show 10 more lines at a time by clicking the little grey “…” symbols. But getting 1000 lines down would take 100 clicks – hardly sensible. Moreover, what if I want to comment on a file that isn’t in the patch at all? Thanks Simon Hi Simon, Go to the source code that you want to refer to, (Repository… Files for example, or even within an MR itself)… and you’ll notice if you hover on the LHS of any source code, next to the line numbers, that it has a little link icon. Clicking that will change the URL in the URL bar to refer to that place (you can also shift-click between two lines to create a range if that’s your particular proclivity). You can copy the link from the URL bar, and then paste it into the comment where you want to refer to the line of code in question. Warmest regards, Julian

Julian Leviston

5:41 a.m.

...

On 18 Feb 2019, at 8:22 pm, Simon Peyton Jones wrote:

Go to the source code that you want to refer to, (Repository… Files for example, or even within an MR itself)… and you’ll notice if you hover on the LHS of any source code, next to the line numbers, that it has a little link icon. Clicking that will change the URL in the URL bar to refer to that place (you can also shift-click between two lines to create a range if that’s your particular proclivity). You can copy the link from the URL bar, and then paste it into the comment where you want to refer to the line of code in question.

My goal is to add a comment to a line in the MR that is not displayed by the MR

If the line is displayed, then yes I can do what you say. But it isn’t!

Zooming off to the repository is not good because while I can get a link to the line, I can’t add a comment; I can only do that in the MR.

Does that make sense?

Simon

My apologies. I knew I couldn’t surely *actually* be able to help SPJ ;-) <grins> Sorry. Just a big fan. I spent 30 minutes searching around and discovered the “special gitlab references” section, which I was only vaguely aware of: https://docs.gitlab.com/ee/user/markdown.html#special-gitlab-references https://docs.gitlab.com/ee/user/markdown.html#special-gitlab-references but I couldn’t for the life of me find a way to do what we can do in github (quote sections of code into a general comment) So, I often have this issue in github, too… sometimes I just want to refer to some file that’s not in the PR at all. My solution is usually to write a general comment, and in the comment, I just paste the link of whatever I want to refer to. It’s a bit naff. As you’re implying, we should be able to add a new comment on any file at all in a repository, *at the point in the version history that the repo was at when you wrote the comment*. Tho, I’m not sure what they’d do to comments that got swept away with rebases and the like (which is probably why it’s not a feature). Might be worth suggesting as a feature. Sorry I wasn’t more helpful, Julian

2284

Age (days ago)

2288

Last active (days ago)

List overview

Download

3 comments

2 participants

participants (2)

Julian Leviston
Simon Peyton Jones