RE: D1428: Rework treatment of wildcards
Ben So that you know, the state of play is: * wip/spj-wildcard-refactor is fully up to speed with HEAD * It validates except for perf/compiler/T3064 (8% loss) * It does need a decent commit message I'd really like this in 8.0: - It's a big patch, so not having it will lead to lots of tiresome cross-branch porting - It does fix things in the wildcard story Of these the former is the more important. The only think holding me up is that I really don't understand the perf regression. It seems to be in the simplifier, which I have not touched! Working on it. But in the worst case I can commit and open a ticket for the perf regression Simon | -----Original Message----- | From: noreply@phabricator.haskell.org | [mailto:noreply@phabricator.haskell.org] | Sent: 26 November 2015 14:40 | To: Simon Peyton Jones <simonpj@microsoft.com> | Subject: [Differential] [Requested Changes To] D1428: Rework treatment | of wildcards | | bgamari requested changes to this revision. | bgamari added a comment. | This revision now requires changes to proceed. | | Requesting changes to bump this out of the review queue. | | | REPOSITORY | rGHC Glasgow Haskell Compiler | | REVISION DETAIL | https://phabricator.haskell.org/D1428 | | EMAIL PREFERENCES | https://phabricator.haskell.org/settings/panel/emailpreferences/ | | To: austin, hvr, goldfire, simonpj, bgamari | Cc: jstolarek, alanz, goldfire, thomie, mpickering, simonpj
Simon Peyton Jones <simonpj@microsoft.com> writes:
Ben
So that you know, the state of play is:
* wip/spj-wildcard-refactor is fully up to speed with HEAD * It validates except for perf/compiler/T3064 (8% loss) * It does need a decent commit message
I'd really like this in 8.0: - It's a big patch, so not having it will lead to lots of tiresome cross-branch porting - It does fix things in the wildcard story Of these the former is the more important.
The only think holding me up is that I really don't understand the perf regression. It seems to be in the simplifier, which I have not touched! Working on it. But in the worst case I can commit and open a ticket for the perf regression
Thanks for the update! Don't worry, there's still time as we're still waiting for D808 which will likely be at least a few more days. Let me know if I can be of assistance. Cheers, - Ben
participants (2)
-
Ben Gamari -
Simon Peyton Jones