
Friends In this MRhttps://gitlab.haskell.org/ghc/ghc/merge_requests/908, Vlad includes the number of the ticket it fixes in the title of the MR. That is so helpful: * It links the MR back to the issue * And does so in large font (screen shot below) * And the link is clickable, even in the title. I suggest we document this in our GHC-best-practice guide, and get everyone to do it. Would you agree Simon [cid:image001.jpg@01D50583.988DEB70]

I agree that this is the way to go. This is part of our contributing guide at work, for the reasons you mentioned. Additionally it helps avoid the need to read the MR's contents (comments/code) before going into it, since reading relevant tickets is almost always something you want to do. Thanks On Wed, May 8, 2019, 4:51 AM Simon Peyton Jones via ghc-devs < ghc-devs@haskell.org> wrote:
Friends
In this MR https://gitlab.haskell.org/ghc/ghc/merge_requests/908, Vlad includes the number of the ticket it fixes *in the title of the MR.*
That is so helpful:
- It links the MR back to the issue - And does so in large font (screen shot below) - And the link is clickable, even in the title.
I suggest we document this in our GHC-best-practice guide, and get everyone to do it.
Would you agree
Simon
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

This is part of our contributing guide at work
Do you have other advice from your contributing guide that we could learn from?
Simon
From: chessai .

Might I also suggest that we put a very brief summary of the area of GHC that the MR fixes in the title? With the way that GitLab puts numbers at the end of subject lines, it's harder to recognize tickets by number now. By including a few keywords in the MR title, I can find ones of interest more easily. Regardless, putting the ticket number in the title should be a higher priority. Richard
On May 8, 2019, at 4:51 AM, Simon Peyton Jones via ghc-devs
wrote: Friends
In this MR https://gitlab.haskell.org/ghc/ghc/merge_requests/908, Vlad includes the number of the ticket it fixes in the title of the MR.
That is so helpful:
It links the MR back to the issue And does so in large font (screen shot below) And the link is clickable, even in the title. I suggest we document this in our GHC-best-practice guide, and get everyone to do it.
Would you agree
Simon
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org mailto:ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
participants (3)
-
chessai .
-
Richard Eisenberg
-
Simon Peyton Jones