Marge Bot repeatedly failing due to stat decreases

Hello, I've been receiving a flurry of e-mails all weekend about Marge Bot failing to validate a batch on CI. Moreover, the failures appear to be consistent each time. From the most recent one [1]: Unexpected stat failures: /builds/ghc/ghc/tmp/ghctest-mel1y5lo/test spaces/testsuite/tests/perf/compiler/T12150.run T12150 [stat decreased from "x86_64-linux-deb9-hadrian" baseline @ HEAD~6] (optasm) /builds/ghc/ghc/tmp/ghctest-mel1y5lo/test spaces/testsuite/tests/perf/compiler/T12234.run T12234 [stat decreased from "x86_64-linux-deb9-hadrian" baseline @ HEAD~6] (optasm) Where T12150(optasm) compile_time/bytes allocated 75982592.000 (baseline @ HEAD~6) 76945688.000 [decreased, -1.3%] T12234(optasm) compile_time/bytes allocated 82149240.000 (baseline @ HEAD~6) 83109896.000 [decreased, -1.2%] Can something be done about this? It's holding one one of my patches. Ryan S. ----- [1] https://gitlab.haskell.org/ghc/ghc/-/jobs/359994

Ryan Scott
Hello,
I've been receiving a flurry of e-mails all weekend about Marge Bot failing to validate a batch on CI. Moreover, the failures appear to be consistent each time. From the most recent one [1]:
Yesterday I had amended one of Marge's batches to accept the performance changes and marked it for auto-merging. Unfortunately Marge got to it before CI finished it and closed it. I just manually merged it and restarted Marge. Sorry for the delay! Cheers, - Ben

Something strange is still going on, since Marge now just opened an
empty merge batch [1].
Ryan S.
-----
[1] https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3465
On Mon, Jun 8, 2020 at 9:37 AM Ben Gamari
Ryan Scott
writes: Hello,
I've been receiving a flurry of e-mails all weekend about Marge Bot failing to validate a batch on CI. Moreover, the failures appear to be consistent each time. From the most recent one [1]:
Yesterday I had amended one of Marge's batches to accept the performance changes and marked it for auto-merging. Unfortunately Marge got to it before CI finished it and closed it.
I just manually merged it and restarted Marge. Sorry for the delay!
Cheers,
- Ben

Thanks Ben! For future reference, is there anything that we as ordinary GHC developers can do to help Marge along when she gets stuck on stat changes? You mentioned that you amended a Marge batch to accept the changes before. Are there instructions on how to do this properly? For instance, which commit(s) in a batch should be amended? Is it better to amend the branch that Marge works on directly, or to update the original MR? Ryan S.
participants (2)
-
Ben Gamari
-
Ryan Scott