How to contribute a patch

Ben The "how to contribute a patch" page https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/fixing-bugs doesn't say anything about the process of actually getting it committed, notably: * Picking approvers * Assigning to Marge * Monitoring progress if it doesn't land within 24 hrs; even knowing when to time out would help. There's a bit of info, rather oddly, on the GHC wiki root page https://gitlab.haskell.org/ghc/ghc/wikis/home The initial stuff about opening a MR is details, but there is not enough on these latter steps I think. I'm cc'ing Sandy He's asking "what next"https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F668%23note_198496&data=01%7C01%7Csimonpj%40microsoft.com%7Ccffab540b753400fffa208d6d94b42f7%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=6Ha%2BqotYMQeWBnMUPUk2mhOIl1wrPI1ZI%2FnNZZszGsE%3D&reserved=0 and I wanted to say "look at the instructions here" but failed to find a suitable "here." Thanks Simon

I made the start of a wiki page about Marge
https://gitlab.haskell.org/ghc/ghc/wikis/Marge-Bot
Matt
On Thu, May 16, 2019 at 1:04 PM Simon Peyton Jones via ghc-devs
Ben
The “how to contribute a patch” page https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/fixing-bugs doesn’t say anything about the process of actually getting it committed, notably:
Picking approvers Assigning to Marge Monitoring progress if it doesn’t land within 24 hrs; even knowing when to time out would help.
There’s a bit of info, rather oddly, on the GHC wiki root page https://gitlab.haskell.org/ghc/ghc/wikis/home
The initial stuff about opening a MR is details, but there is not enough on these latter steps I think.
I’m cc’ing Sandy He’s asking “what next” and I wanted to say “look at the instructions here” but failed to find a suitable “here.”
Thanks
Simon
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Matthew Pickering
I made the start of a wiki page about Marge
Thank you Matthew! I also think there is more to be said here; I'll add this to my todo this. Cheers, - Ben
participants (3)
-
Ben Gamari
-
Matthew Pickering
-
Simon Peyton Jones