David, are you sure we want to accept a more than 5% increase in compile time without investigation? What commit caused these increases? Maybe they are readily squashed? Generally we are trying to improve compiler perf not accept it getting worse! Simon | -----Original Message----- | From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf Of | git@git.haskell.org | Sent: 28 August 2017 19:34 | To: ghc-commits@haskell.org | Subject: [commit: ghc] master: Adjust test suite stats (a055f24) | | Repository : ssh://git@git.haskell.org/ghc | | On branch : master | Link : | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske | ll.org%2Ftrac%2Fghc%2Fchangeset%2Fa055f240aeda538c656a59e810870e6a2ccc2db | 7%2Fghc&data=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4 | ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722& | sdata=WH8x1FkDCAmRas%2F5CIxA7PmqDj1zzfqApfyowKlGdfo%3D&reserved=0 | | >--------------------------------------------------------------- | | commit a055f240aeda538c656a59e810870e6a2ccc2db7 | Author: David Feuer <David.Feuer@gmail.com> | Date: Mon Aug 28 14:35:19 2017 -0400 | | Adjust test suite stats | | T1969 and T12150 were failing (stat too high) | | | >--------------------------------------------------------------- | | a055f240aeda538c656a59e810870e6a2ccc2db7 | testsuite/tests/perf/compiler/all.T | 6 ++++-- | 1 file changed, 4 insertions(+), 2 deletions(-) | | diff --git a/testsuite/tests/perf/compiler/all.T | b/testsuite/tests/perf/compiler/all.T | index 1da2883..cf49981 100644 | --- a/testsuite/tests/perf/compiler/all.T | +++ b/testsuite/tests/perf/compiler/all.T | @@ -72,7 +72,7 @@ test('T1969', | # 2017-03-24 9261052 (x86/Linux, 64-bit machine) | # 2017-04-06 9418680 (x86/Linux, 64-bit machine) | | - (wordsize(64), 16679176, 15)]), | + (wordsize(64), 19199872, 15)]), | # 2014-09-10 10463640, 10 # post-AMP-update (somewhat | stabelish) | # looks like the peak is around ~10M, but we're | # unlikely to GC exactly on the peak. | @@ -87,6 +87,7 @@ test('T1969', | # 2017-02-01 19924328 (amd64/Linux) Join points (#12988) | # 2017-02-14 16393848 Early inline patch | # 2017-03-31 16679176 Fix memory leak in simplifier | + # 2017-08-25 19199872 Refactor the Mighty Simplifier | | compiler_stats_num_field('bytes allocated', | [(platform('i386-unknown-mingw32'), 301784492, 5), @@ -1110,7 | +1111,8 @@ test('T12150', | [ only_ways(['optasm']), | compiler_stats_num_field('bytes allocated', | [(wordsize(64), 70773000, 5) | - # initial: 70773000 | + # initial: 70773000 | + # 2017-08-25: 74358208 Refactor the Mighty Simplifier | ]), | ], | compile, | | _______________________________________________ | ghc-commits mailing list | ghc-commits@haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask | ell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | commits&data=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4 | ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722& | sdata=j5wIO8m%2FgR3czmSfjpJlzV4HcMbwrI3nU2C98OmMkV0%3D&reserved=0