Ben
Why did you revert this?
commit 2756117bd26c2cb70d3f51954a88b7d7bdf3d3f2
Author: Ben Gamari
I commented on https://phabricator.haskell.org/rGHCd675a354e8db67d87d1f257c3d1d2bf2d58c2b3f
that Harbormaster started failing after this.
It reproduced locally for me.
You can see here:
https://phabricator.haskell.org/diffusion/GHC/history/master/ that the
revert fixed the build.
2018-03-05 8:50 GMT+00:00 Simon Peyton Jones via ghc-devs
Ben
Why did you revert this?
commit 2756117bd26c2cb70d3f51954a88b7d7bdf3d3f2
Author: Ben Gamari
Date: Thu Mar 1 14:06:04 2018 -0500
Revert "Better stats for T5837"
This reverts commit d675a354e8db67d87d1f257c3d1d2bf2d58c2b3f.
- (wordsize(64), 55813608, 7)])
+ (wordsize(64), 51294232, 7)])
It’s consistently 8% better for me, but I guess not for you.
Does anyone else find this?
Simon
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Simon Peyton Jones via ghc-devs
Ben Why did you revert this?
As Bartosz mentioned, Harbormaster didn't reproduce the change. I've also not seen it locally. Admittedly, it possible that it does change on Harbormaster, just by a much different amount than what you observed. Cheers, - Ben
participants (3)
-
Bartosz Nitka -
Ben Gamari -
Simon Peyton Jones