GitLab CI for patches across submodules
Hi, I just tried to use GitLab CI to validate a GHC patch including changes to Haddock: https://gitlab.haskell.org/sjakobi/ghc/pipelines/842 The problem is that the CI script tries to find my Haddock commit at https://gitlab.haskell.org/ghc/haddock. But that repo doesn't even allow merge request. Should the submodule origin for util/haddock maybe point at https://github.com/haskell/haddock instead? Cheers, Simon
Simon Jakobi via ghc-devs
Hi,
I just tried to use GitLab CI to validate a GHC patch including changes to Haddock: https://gitlab.haskell.org/sjakobi/ghc/pipelines/842
The problem is that the CI script tries to find my Haddock commit at https://gitlab.haskell.org/ghc/haddock. But that repo doesn't even allow merge request.
Should the submodule origin for util/haddock maybe point at https://github.com/haskell/haddock instead?
In general we want to ensure that only *.haskell.org hosts are relied on during normal builds (since some users build artifacts under very restrictive sandbox conditions). However, we can certainly use the upstream repo during CI builds. I have opened !78 which should hopefully fix this. Perhaps you could rebase on topp of this and check? Cheers, - Ben
Am Sa., 5. Jan. 2019 um 22:18 Uhr schrieb Ben Gamari
Thanks, Ben, that works for me. What I hadn't realized before, is that having my haddock commit in my Gitlab fork (sjakobi/haddock) apparently also makes it accessible through ghc/haddock. What is my-branch in sjakobi/haddock is sjakobi/my-branch in ghc/haddock. Cheers, Simon
participants (2)
-
Ben Gamari -
Simon Jakobi