Request for two new MR-labels: "review-needed" and "changes-required"

Hello devs, Recently in a MR discussion the topic came up of contributors being frustrated about lack of reviews. As a contributor and as a reviewer the lack of tools to find MR's in need of attention also frustrated me often. I suggest two new MR labels: Label: "review-needed": If a contributor has an MR which he considers to be blocked on (lack of) review he can assign the label to clearly signal this. Label: "changes-required": This is the inverse - if a reviewer looked at a patch and it's clear that the patch needs more work from the contributor this label can signal this. What are the benefits? * As a reviewer I can look for MR's tagged with review-needed and can be sure that time spent reviewing is not wasted. * As a contributor I can mark a patch as changes-required if I think my patch is ready to land, or if I need input on the design. * Core maintainers can more easily identify patches which have been stalled for a long time, making their review a priority. The obvious downside is more labels. Cheers Andreas

Andreas Klebinger
Hello devs,
Recently in a MR discussion the topic came up of contributors being frustrated about lack of reviews.
As a contributor and as a reviewer the lack of tools to find MR's in need of attention also frustrated me often.
I suggest two new MR labels:
I believe we already have a solution to this problem, which is outlined here [1]. I have created the necessary labels however haven't updated our contributor documentation to reflect the new workflow. Cheers, - Ben [1] https://docs.google.com/document/d/1-xPFaYdwhAlwOO0PLGwN3PxFLpwsYwjtWsVVALbO...

Hi Ben, Thanks for reminding me about that document. Has it been officially ratified as our procedure of record? My guess is "no". What's it waiting on? That document has been around for quite some time now. Thanks, Richard
On Feb 7, 2020, at 9:32 PM, Ben Gamari
wrote: Andreas Klebinger
writes: Hello devs,
Recently in a MR discussion the topic came up of contributors being frustrated about lack of reviews.
As a contributor and as a reviewer the lack of tools to find MR's in need of attention also frustrated me often.
I suggest two new MR labels:
I believe we already have a solution to this problem, which is outlined here [1]. I have created the necessary labels however haven't updated our contributor documentation to reflect the new workflow.
Cheers,
- Ben
[1] https://docs.google.com/document/d/1-xPFaYdwhAlwOO0PLGwN3PxFLpwsYwjtWsVVALbO... _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
participants (3)
-
Andreas Klebinger
-
Ben Gamari
-
Richard Eisenberg