eqExprX - dead code?

Hi, I came across some seemingly dead code, but I’d like to ask here before I clean it up. (Generally, cleaning up dead code is desirable, right?) The function eqExprX takes a parameter id_unfolding_fun which allows it to look through variable unfoldings. But the only use of this fuction is in eqExpr, which passes "const noUnfolding". Therefore, the two fancy cases in lines 1351-1362 never apply: http://git.haskell.org/ghc.git/blob/HEAD:/compiler/coreSyn/CoreUtils.lhs#l13... Some archeology: In Dec 2010, SPJ removed a use of eqExprX from the CSE module, which made use of that parameter (aae915d6). Thinking about it, it is probably safe to clean up the code. And if not, I’m not going to be offended by a "git revert", but just doing the change instead of waiting for permission seems to be more efficient to me. Greetings, Joachim -- Joachim “nomeata” Breitner mail@joachim-breitner.de • http://www.joachim-breitner.de/ Jabber: nomeata@joachim-breitner.de • GPG-Key: 0x4743206C Debian Developer: nomeata@debian.org
participants (1)
-
Joachim Breitner