Re: [commit: ghc] master: Improve pretty-printing of types (66c5ddb)

This commit broke the build:
ghc/InteractiveUI.hs:1986:18:
Not in scope: data constructor 'Opt_PrintKindArgs'
The commit is missing the author name and email so I don't know who to
contact directly.
On Tue, Oct 1, 2013 at 8:55 AM,
Repository : ssh://git@git.haskell.org/ghc
On branch : master Link : http://ghc.haskell.org/trac/ghc/changeset/66c5ddba449e78a174e989ea35783eb6c7...
---------------------------------------------------------------
commit 66c5ddba449e78a174e989ea35783eb6c793e483 Author: unknown
Date: Tue Oct 1 16:34:00 2013 +0100 Improve pretty-printing of types
* The main change is to suppress printing (in types) of kind for-alls kind applications The new flag -fprint-explicit-kinds prints them as before (by analogy with the existing -fprint-explicit-foralls)
* I also took advantage of the fact that SDoc now has access to DynFlags, to tidy up the way in which explicit for-alls are printed. Instead of passing a boolean flag around, we now simply consult the DynFlags. Much neater.
I still need to add documentation for the flag
---------------------------------------------------------------
66c5ddba449e78a174e989ea35783eb6c793e483 compiler/ghci/Debugger.hs | 5 +- compiler/main/DynFlags.hs | 2 + compiler/main/PprTyThing.hs | 156 ++++++++++++++++++++++--------------------- compiler/types/TypeRep.lhs | 126 ++++++++++++++++++++++------------ ghc/InteractiveUI.hs | 52 ++++++--------- 5 files changed, 189 insertions(+), 152 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 66c5ddba449e78a174e989ea35783eb6c793e483 _______________________________________________ ghc-commits mailing list ghc-commits@haskell.org http://www.haskell.org/mailman/listinfo/ghc-commits

Btw, setting the name and email address can be done with:
$ git config --global user.name "John Doe"
$ git config --global user.email johndoe@example.com
On Tue, Oct 1, 2013 at 9:39 AM, Johan Tibell
This commit broke the build:
ghc/InteractiveUI.hs:1986:18: Not in scope: data constructor 'Opt_PrintKindArgs'
The commit is missing the author name and email so I don't know who to contact directly.
On Tue, Oct 1, 2013 at 8:55 AM,
wrote: Repository : ssh://git@git.haskell.org/ghc
On branch : master Link : http://ghc.haskell.org/trac/ghc/changeset/66c5ddba449e78a174e989ea35783eb6c7...
---------------------------------------------------------------
commit 66c5ddba449e78a174e989ea35783eb6c793e483 Author: unknown
Date: Tue Oct 1 16:34:00 2013 +0100 Improve pretty-printing of types
* The main change is to suppress printing (in types) of kind for-alls kind applications The new flag -fprint-explicit-kinds prints them as before (by analogy with the existing -fprint-explicit-foralls)
* I also took advantage of the fact that SDoc now has access to DynFlags, to tidy up the way in which explicit for-alls are printed. Instead of passing a boolean flag around, we now simply consult the DynFlags. Much neater.
I still need to add documentation for the flag
---------------------------------------------------------------
66c5ddba449e78a174e989ea35783eb6c793e483 compiler/ghci/Debugger.hs | 5 +- compiler/main/DynFlags.hs | 2 + compiler/main/PprTyThing.hs | 156 ++++++++++++++++++++++--------------------- compiler/types/TypeRep.lhs | 126 ++++++++++++++++++++++------------ ghc/InteractiveUI.hs | 52 ++++++--------- 5 files changed, 189 insertions(+), 152 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 66c5ddba449e78a174e989ea35783eb6c793e483 _______________________________________________ ghc-commits mailing list ghc-commits@haskell.org http://www.haskell.org/mailman/listinfo/ghc-commits
participants (1)
-
Johan Tibell