Hi Erik, I'm not sure if the hsc2hs repo [1] has "official" Phabricator integration, but what I did when I submitted a patch to hsc2hs was: 1. Commit your changes 2. Because the hsc2hs repo doesn't have an .arcconfig file, you have to manually point arcanist to the right URL by running: arc diff --conduit-uri=https://phabricator.haskell.org Ryan S. ----- [1] http://git.haskell.org/hsc2hs.git
Ryan Scott wrote:
Hi Erik,
I'm not sure if the hsc2hs repo [1] has "official" Phabricator integration, but what I did when I submitted a patch to hsc2hs was:
1. Commit your changes 2. Because the hsc2hs repo doesn't have an .arcconfig file, you have to manually point arcanist to the right URL by running:
arc diff --conduit-uri=https://phabricator.haskell.org
How long ago was it that it worked, because it doesn't now. I get: Exception ERR-CONDUIT-CORE: Validation errors: - Creation of this diff was rejected by Herald rule H51. Rule: Reject diffs with no repository set Reason: You must specify an existing repository to attach the diff to. (Run with `--trace` for a full exception trace.) Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:
How long ago was it that it worked, because it doesn't now.
With a little help from mpickering I got this up on Phab: https://phabricator.haskell.org/D2677 Thanks Matt! Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
To close up this thread, once D2676 is merged to hsc2hs then you will be
able to submit patches using the same workflow as for GHC.
On Friday, 4 November 2016, Erik de Castro Lopo
Erik de Castro Lopo wrote:
How long ago was it that it worked, because it doesn't now.
With a little help from mpickering I got this up on Phab:
https://phabricator.haskell.org/D2677
Thanks Matt!
Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org javascript:; http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
participants (3)
-
Erik de Castro Lopo -
Matthew Pickering -
Ryan Scott