RE: [commit: base] master: Change rules for RealFrac methods to pointfree, so that they can also fire in pointfree use. (4036a1a)
| Change rules for RealFrac methods to pointfree, so that they can also fire in | pointfree use. Good, thanks . But could you add a Note [Write rules in point-free style ~~~~~~~~~~~~~~~~~~~~~~ to explain what the motivating reason for the change is. Also an example or two. Perhaps there is a ticket that motivates it? Maybe refer to the Note from all the places where it is important? Simon | -----Original Message----- | From: ghc-commits-bounces@haskell.org [mailto:ghc-commits- | bounces@haskell.org] On Behalf Of Daniel Fischer | Sent: 27 February 2013 13:58 | To: ghc-commits@haskell.org | Subject: [commit: base] master: Change rules for RealFrac methods to pointfree, | so that they can also fire in pointfree use. (4036a1a) | | Repository : ssh://darcs.haskell.org//srv/darcs/packages/base | | On branch : master | | http://hackage.haskell.org/trac/ghc/changeset/4036a1ae7a9694c9c69749ec8e36 | 143c31bce976 | | >--------------------------------------------------------------- | | commit 4036a1ae7a9694c9c69749ec8e36143c31bce976 | Author: Daniel Fischer <daniel.is.fischer@googlemail.com> | Date: Wed Feb 13 16:10:12 2013 +0100 | | Change rules for RealFrac methods to pointfree, so that they can also fire in | pointfree use. | | GHC/Int.hs | 96 +++++++++++++++++++++++++++++------------------ | ----------- | GHC/Word.hs | 72 ++++++++++++++++++++++---------------------- | 2 files changed, 84 insertions(+), 84 deletions(-) | | | Diff suppressed because of size. To see it, use: | | git show 4036a1ae7a9694c9c69749ec8e36143c31bce976 | | _______________________________________________ | ghc-commits mailing list | ghc-commits@haskell.org | http://www.haskell.org/mailman/listinfo/ghc-commits
On Wednesday 27 February 2013, 14:45:35, Simon Peyton-Jones wrote:
Good, thanks . But could you add a Note [Write rules in point-free style ~~~~~~~~~~~~~~~~~~~~~~
Okay, I'm going to write a note, just need to figure out where to put it.
to explain what the motivating reason for the change is. Also an example or two. Perhaps there is a ticket that motivates it?
A Stack Overflow question, http://stackoverflow.com/questions/14820699/truncating-to-word-type alerted me to the fact that the rule(s) didn't fire in point-free use.
Maybe refer to the Note from all the places where it is important?
Simon
Cheers, Daniel P.S.: I'm afraid I accidentally pushed two (trivial, fortunately) merge commits, sorry. Some day I may figure out how to use git.
participants (2)
-
Daniel Fischer -
Simon Peyton-Jones