Bother. Sorry, I did validate, but maybe not clean enough... | -----Original Message----- | From: ghc-commits On Behalf Of | git@git.haskell.org | Sent: 01 August 2018 11:55 | To: ghc-commits@haskell.org | Subject: [commit: ghc] master: Revert "Don't inline functions with RULES too | early" (1df50a0) | | Repository : ssh://git@git.haskell.org/ghc | | On branch : master | Link : | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haskell. | org%2Ftrac%2Fghc%2Fchangeset%2F1df50a0f61f320428f2e6dd07b3c9ce49c4acd31%2Fgh | c&data=02%7C01%7Csimonpj%40microsoft.com%7Cf0f94d0215cc45d3c05f08d5f79d3 | bcf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636687177045114421&sdat | a=KJfA0OCKfpsAKB0Zz8Z%2FS9mnqr3D3gLhn6AYd7ddzE4%3D&reserved=0 | | >--------------------------------------------------------------- | | commit 1df50a0f61f320428f2e6dd07b3c9ce49c4acd31 | Author: Ben Gamari | Date: Wed Aug 1 06:42:19 2018 -0400 | | Revert "Don't inline functions with RULES too early" | | This commit causes significant performance regressions: | ``` | bytes allocated value is too high: | Expected T9872d(normal) bytes allocated: 578498120 +/-5% | Lower bound T9872d(normal) bytes allocated: 549573214 | Upper bound T9872d(normal) bytes allocated: 607423026 | Actual T9872d(normal) bytes allocated: 677179968 | Deviation T9872d(normal) bytes allocated: 17.1 % | bytes allocated value is too high: | Expected T9872c(normal) bytes allocated: 3096670112 +/-5% | Lower bound T9872c(normal) bytes allocated: 2941836606 | Upper bound T9872c(normal) bytes allocated: 3251503618 | Actual T9872c(normal) bytes allocated: 3601872536 | Deviation T9872c(normal) bytes allocated: 16.3 % | bytes allocated value is too high: | Expected T9872b(normal) bytes allocated: 3730686224 +/-5% | Lower bound T9872b(normal) bytes allocated: 3544151912 | Upper bound T9872b(normal) bytes allocated: 3917220536 | Actual T9872b(normal) bytes allocated: 4374298272 | Deviation T9872b(normal) bytes allocated: 17.3 % | bytes allocated value is too high: | Expected T9872a(normal) bytes allocated: 2729927408 +/-5% | Lower bound T9872a(normal) bytes allocated: 2593431037 | Upper bound T9872a(normal) bytes allocated: 2866423779 | Actual T9872a(normal) bytes allocated: 3225788896 | Deviation T9872a(normal) bytes allocated: 18.2 % | ``` | It's not clear that this was intentional so I'm going to revert for now. | | This reverts commit 2110738b280543698407924a16ac92b6d804dc36. | | | >--------------------------------------------------------------- | | 1df50a0f61f320428f2e6dd07b3c9ce49c4acd31 | compiler/basicTypes/BasicTypes.hs | 10 ----- | compiler/basicTypes/MkId.hs | 2 +- | compiler/specialise/Rules.hs | 49 ++++--------------- | --- | compiler/stranal/WorkWrap.hs | 4 +- | testsuite/tests/simplCore/should_compile/T15445.hs | 8 ---- | .../tests/simplCore/should_compile/T15445.stderr | 13 ------ | .../tests/simplCore/should_compile/T15445a.hs | 10 ----- | testsuite/tests/simplCore/should_compile/all.T | 1 - | 8 files changed, 10 insertions(+), 87 deletions(-) | | Diff suppressed because of size. To see it, use: | | git diff-tree --root --patch-with-stat --no-color --find-copies-harder - | -ignore-space-at-eol --cc 1df50a0f61f320428f2e6dd07b3c9ce49c4acd31 | _______________________________________________ | ghc-commits mailing list | ghc-commits@haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haskell | .org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | commits&data=02%7C01%7Csimonpj%40microsoft.com%7Cf0f94d0215cc45d3c05f08d | 5f79d3bcf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636687177045114421&am | p;sdata=7D%2F6r1pP1Pizyev6tFZzHW9pJEsRxwd1r7AnX44KSdc%3D&reserved=0