Friends I think HsTick and HsBinTick are added (only) by GHC.HsToCore.Coverage So I think the cannot occur in HsExpr GhcPs or HcExpr GhcRn If so we should change the data type decl to say this explicitly. Can anyone confirm or deny and add a ticket if so? Simon
I confirm. I added this in the description of https://gitlab.haskell.org/ghc/ghc/issues/16830. Krzysztof On Mon, Apr 13, 2020 at 1:00 PM Simon Peyton Jones via ghc-devs < ghc-devs@haskell.org> wrote:
Friends
I think HsTick and HsBinTick are added (only) by GHC.HsToCore.Coverage
So I think the cannot occur in HsExpr GhcPs or HcExpr GhcRn
If so we should change the data type decl to say this explicitly.
Can anyone confirm or deny and add a ticket if so?
Simon
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
FWIW, I fixed some code paths (locally) in the compiler before to not panic when using the `HsTick` constructor as I wanted to generate some code using Template Haskell which contained source notes. This was useful for me for debugging a big explosion in code generation size. On Mon, Apr 13, 2020 at 5:50 PM Krzysztof Gogolewski <krz.gogolewski@gmail.com> wrote:
I confirm. I added this in the description of https://gitlab.haskell.org/ghc/ghc/issues/16830. Krzysztof
On Mon, Apr 13, 2020 at 1:00 PM Simon Peyton Jones via ghc-devs <ghc-devs@haskell.org> wrote:
Friends
I think HsTick and HsBinTick are added (only) by GHC.HsToCore.Coverage
So I think the cannot occur in HsExpr GhcPs or HcExpr GhcRn
If so we should change the data type decl to say this explicitly.
Can anyone confirm or deny and add a ticket if so?
Simon
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
participants (3)
-
Krzysztof Gogolewski -
Matthew Pickering -
Simon Peyton Jones