We are currently wrapping up https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12842, which moves Fixity declarations into TTG extensions point, and into the haskell syntax, not GHC. But rnCmd for HsCommandArrForm in current master has rnCmd (HsCmdArrForm _ op _ (Just _) [arg1, arg2]) ... It matches on HsCmd GhcPs, which never introduce the `Just` form for fixity. The only place the `Just` form is introduced, is in mkOpFormRn, but this is only ever called from this specific equation. So both can be removed, without changing behaviour. The question is, this code was added for a reason at some point, what has broken in the meantime? Should this be fixed somehow instead of being removed? Alan
That looks strange. I would just blaze ahead and do what seems sensible.
That (Just _) equation was introduced by Daniel Winorgrad-Cort in the
commit below. You could try to see what that commit did, I suppose.
(Twelve years ago.)
Arrows are sadly un-loved (need a champion) so I think you'll just have to
do your best.
Simon
*commit ba56d20d767f0425f6f7515fa9c78b186589b896*
Author: Simon Peyton Jones
We are currently wrapping up https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12842, which moves Fixity declarations into TTG extensions point, and into the haskell syntax, not GHC.
But rnCmd for HsCommandArrForm in current master has
rnCmd (HsCmdArrForm _ op _ (Just _) [arg1, arg2]) ...
It matches on HsCmd GhcPs, which never introduce the `Just` form for fixity.
The only place the `Just` form is introduced, is in mkOpFormRn, but this is only ever called from this specific equation. So both can be removed, without changing behaviour.
The question is, this code was added for a reason at some point, what has broken in the meantime? Should this be fixed somehow instead of being removed?
Alan _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
participants (2)
-
Alan & Kim Zimmerman -
Simon Peyton Jones