Joachim The commit message says something about "tick reports", but the change to the code is entirely un-commented, and appears to have nothing to do with ticky reports. Could you add a comment or Note to explain? Thanks! Simon | -----Original Message----- | From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf Of | git@git.haskell.org | Sent: 14 April 2016 21:35 | To: ghc-commits@haskell.org | Subject: [commit: ghc] wip/T10613: State hack hack in ticky report | (02493dc) | | Repository : ssh://git@git.haskell.org/ghc | | On branch : wip/T10613 | Link : | https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fghc.has | kell.org%2ftrac%2fghc%2fchangeset%2f02493dcf580141110e90fa943ec70640115 | de0ed%2fghc&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7c306055dca | afa407e7ce708d364a49c11%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=d% | 2f7isihh6dMDZX93hTY8rsMQ7y%2f6mkiDm2asfPXpMrQ%3d | | >--------------------------------------------------------------- | | commit 02493dcf580141110e90fa943ec70640115de0ed | Author: Joachim Breitner | Date: Wed Mar 23 11:10:25 2016 +0100 | | State hack hack in ticky report | | In the ticky report, do not mark a function with a State# argument | as | its first argument as single-entry. | | | >--------------------------------------------------------------- | | 02493dcf580141110e90fa943ec70640115de0ed | compiler/codeGen/StgCmmClosure.hs | 5 ++++- | 1 file changed, 4 insertions(+), 1 deletion(-) | | diff --git a/compiler/codeGen/StgCmmClosure.hs | b/compiler/codeGen/StgCmmClosure.hs | index b467048..3b83b8e 100644 | --- a/compiler/codeGen/StgCmmClosure.hs | +++ b/compiler/codeGen/StgCmmClosure.hs | @@ -234,7 +234,10 @@ mkLFReEntrant _ _ [] _ | = pprPanic "mkLFReEntrant" empty | mkLFReEntrant top fvs args arg_descr | = LFReEntrant top os_info (length args) (null fvs) arg_descr | - where os_info = idOneShotInfo (head args) | + where | + state_hack_hack = isStateHackType (idType (head args)) | + os_info | state_hack_hack = noOneShotInfo | + | otherwise = idOneShotInfo (head args) | | ------------- | mkLFThunk :: Type -> TopLevelFlag -> [Id] -> UpdateFlag -> | LambdaFormInfo | | _______________________________________________ | ghc-commits mailing list | ghc-commits@haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail.ha | skell.org%2fcgi-bin%2fmailman%2flistinfo%2fghc- | commits&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7c306055dcaafa4 | 07e7ce708d364a49c11%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=c0Gvy1 | OhKUN%2f%2f5Gtx9pCjHEFyj0FMdQBuEzEF4bfvio%3d