no no it was a good reminder. I'd forgotten. http://hackage.haskell.org/trac/ghc/ticket/8036 | -----Original Message----- | From: Gabor Greif [mailto:ggreif@gmail.com] | Sent: 04 July 2013 09:19 | To: Simon Peyton-Jones | Cc: ghc-devs@haskell.org | Subject: Re: [commit: ghc] master: Comment out a leftover pprTrace | (a5b7ee5) | | On 7/4/13, Simon Peyton-Jones wrote: | > Actually that pprTrace is deliberate! Something is wrong if we have | more | > than 10 iterations in the fixpoint loop and I'd like to know. | | Hi Simon, | | one could activate tracing on that condition (if there is | something concrete to branch on). | | I'll gladly revert and include this if you wish. | | Sorry for the trouble :-( | | Cheers, | | Gabor | | > | > Actually this *is* happening right now (I should make a ticket). I | know why | > but have not worked out a good way to fix it. And POPL is pressing. | Anyway | > leave it for now and I'll make a ticket | > | > S | > | > | -----Original Message----- | > | From: ghc-commits-bounces@haskell.org [mailto:ghc-commits- | > | bounces@haskell.org] On Behalf Of Gabor Greif | > | Sent: 03 July 2013 21:58 | > | To: ghc-commits@haskell.org | > | Subject: [commit: ghc] master: Comment out a leftover pprTrace | (a5b7ee5) | > | | > | Repository : http://darcs.haskell.org/ghc.git/ | > | | > | On branch : master | > | | > | | https://github.com/ghc/ghc/commit/a5b7ee5fc26ac322e7dc79de96e478cde81964 | > | 0c | > | | > | >--------------------------------------------------------------- | > | | > | commit a5b7ee5fc26ac322e7dc79de96e478cde819640c | > | Author: Gabor Greif | > | Date: Wed Jul 3 22:56:23 2013 +0200 | > | | > | Comment out a leftover pprTrace | > | | > | >--------------------------------------------------------------- | > | | > | compiler/stranal/DmdAnal.lhs | 14 +++++++------- | > | 1 file changed, 7 insertions(+), 7 deletions(-) | > | | > | diff --git a/compiler/stranal/DmdAnal.lhs | b/compiler/stranal/DmdAnal.lhs | > | index 572a39d..0aff8ff 100644 | > | --- a/compiler/stranal/DmdAnal.lhs | > | +++ b/compiler/stranal/DmdAnal.lhs | > | @@ -26,7 +26,7 @@ import Data.List | > | import DataCon | > | import Id | > | import CoreUtils ( exprIsHNF, exprType, exprIsTrivial ) | > | -import PprCore | > | +-- import PprCore | > | import TyCon | > | import Type ( eqType ) | > | -- import Pair | > | @@ -536,12 +536,12 @@ dmdFix top_lvl env orig_pairs | > | -- iteration of sigs. | > | | > | | n >= 10 | > | - = pprTrace "dmdFix loop" (ppr n <+> (vcat | > | - [ text "Sigs:" <+> ppr [ (id,lookupVarEnv (sigEnv env) | > | id, | > | - lookupVarEnv | > | (sigEnv env') id) | > | - | (id,_) <- pairs], | > | - text "env:" <+> ppr env, | > | - text "binds:" <+> pprCoreBinding (Rec pairs)])) | > | + = -- pprTrace "dmdFix loop" (ppr n <+> (vcat | > | + -- [ text "Sigs:" <+> ppr [ | (id,lookupVarEnv | > | (sigEnv env) id, | > | + -- | lookupVarEnv | > | (sigEnv env') id) | > | + -- | (id,_) <- | pairs], | > | + -- text "env:" <+> ppr env, | > | + -- text "binds:" <+> pprCoreBinding (Rec | > | pairs)])) | > | (env, lazy_fv, orig_pairs) -- Safe output | > | -- The lazy_fv part is really important! orig_pairs has no | > | strictness | > | -- info, including nothing about free vars. But if we have | > | | > | | > | | > | _______________________________________________ | > | ghc-commits mailing list | > | ghc-commits@haskell.org | > | http://www.haskell.org/mailman/listinfo/ghc-commits | > | > _______________________________________________ | > ghc-devs mailing list | > ghc-devs@haskell.org | > http://www.haskell.org/mailman/listinfo/ghc-devs | >